feat: add verification report need type - #660
Merged
Merged
Conversation
Adds the mod_ver_report need type to the metamodel with an evidence extra link, documents the tool requirement, and adds option tests. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
FScholPer
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
dcalavrezo-qorix and
nradakovic
as code owners
July 23, 2026 14:55
6 tasks
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
FScholPer
changed the title
aschemmel-tech
left a comment
aschemmel-tech
left a comment
Contributor
There was a problem hiding this comment.
Made some remarks, not crucial for the PoC
| verification_method: ^.*$ | ||
| optional_options: | ||
| requirements_coverage_percent: ^(100|[1-9]?[0-9])$ | ||
| structural_coverage_percent: ^(100|[1-9]?[0-9])$ |
Contributor
There was a problem hiding this comment.
An overall value I do not think helpful
Contributor
Author
There was a problem hiding this comment.
Dropped the ambiguous overall structural_coverage_percent entirely; now only the concrete line_coverage_percent and branch_coverage_percent remain.
Contributor
There was a problem hiding this comment.
You misunderstood my comment, what I meant was that a 90% gathered over all the units in a module is maybe not really interesting. For example you could have 90% coverage in all units or 100% in only 9 out of 10 - and 0% in one unit - which would be quite a different meaning but both would result in the same "overall" value. But as the PLs will be the main users of this report and you think it helpful ...
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
@aschemmel-tech fixed. Can you check again? |
AlexanderLanin
approved these changes
Jul 30, 2026
AlexanderLanin
left a comment
AlexanderLanin
left a comment
Member
There was a problem hiding this comment.
This is 100% backwards compatible as far as I can tell. Merging.
AlexanderLanin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #611
Split out of #612 (verification part). The inspection-record part is in a separate PR.
📌 Description
Adds a machine-readable module verification report need type to the metamodel.
metamodel.yaml: newmod_ver_reportneed type (prefix: mod_vrep__) classifying a report bysafety,security,statusandverification_method, with optional coverage/verdict/version attributes; linksbelongs_toamodand optionallycontains/covers/evidence/realizes. Adds theevidenceextra link (evidence/evidence_for) it depends on.requirements.rst: new "Verification Evidence" section withtool_req__docs_verification_report_need, plus theVerifrow in the requirements overview table.rst/options/test_options_verification_report.rstcovering a valid report and an invalidverdictvalue.🚨 Impact Analysis
✅ Checklist
Frank Scholter Peres frank.scholter_peres@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH
Provider Information