fix(mw/com): remove noexcept from functions that can propagate except… - #807
Draft
castler wants to merge 1 commit into
Draft
fix(mw/com): remove noexcept from functions that can propagate except…#807castler wants to merge 1 commit into
castler wants to merge 1 commit into
Conversation
…ions Resolves all 122 open CodeQL/MISRA findings for rule cpp/misra/noexcept-function-should-not-propagate-to-the-caller on main. The flagged functions were declared noexcept(true) but the analyzer can prove they may propagate std::bad_variant_access, std::bad_optional_access or std::system_error (from std::visit / std::optional access / inotify). None of them are swap or move operations, so the fix is to drop the noexcept specifier. Declarations and definitions are kept in sync, and for flagged virtual functions the noexcept was also removed from the interface base declaration and sibling overrides (subscription state machine, IServiceDiscovery(Client), ITracingRuntime, IBindingTracingRuntime, IRuntime, proxy/skeleton bindings, binding factories) plus their mocks. Destructors (~ServerConnection, ~TypeErasedCallQueue) are implicitly noexcept(true); they are marked noexcept(false) so the finding clears. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ions
Resolves all 122 open CodeQL/MISRA findings for rule cpp/misra/noexcept-function-should-not-propagate-to-the-caller on main.
The flagged functions were declared noexcept(true) but the analyzer can prove they may propagate std::bad_variant_access, std::bad_optional_access or std::system_error (from std::visit / std::optional access / inotify). None of them are swap or move operations, so the fix is to drop the noexcept specifier. Declarations and definitions are kept in sync, and for flagged virtual functions the noexcept was also removed from the interface base declaration and sibling overrides (subscription state machine, IServiceDiscovery(Client), ITracingRuntime, IBindingTracingRuntime, IRuntime, proxy/skeleton bindings, binding factories) plus their mocks.
Destructors (~ServerConnection, ~TypeErasedCallQueue) are implicitly noexcept(true); they are marked noexcept(false) so the finding clears.