Skip to content

During delete, report progress only on original thread#2820

Merged
iloveeclipse merged 1 commit into
eclipse-platform:masterfrom
iloveeclipse:issue_2819
Jul 21, 2026
Merged

During delete, report progress only on original thread#2820
iloveeclipse merged 1 commit into
eclipse-platform:masterfrom
iloveeclipse:issue_2819

Conversation

@iloveeclipse

Copy link
Copy Markdown
Member

Fixes #2819

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Test Results

    54 files  ±0      54 suites  ±0   55m 47s ⏱️ - 1m 8s
 4 687 tests ±0   4 665 ✅ ±0   22 💤 ±0  0 ❌ ±0 
11 955 runs  ±0  11 802 ✅ ±0  153 💤 ±0  0 ❌ ±0 

Results for commit 9ba7c71. ± Comparison against base commit 00a2d52.

♻️ This comment has been updated with latest results.

Progress monitors given to the `LocalFile.delete(int, IProgressMonitor)`
may require UI access, so reporting work from background thread will
break delete operation. To avoid that, report progress on given monitor
only if operating on the original thread.

Fixes eclipse-platform#2819
@iloveeclipse iloveeclipse changed the title Check provided monitor before deleting files in background During delete, report progress only on original thread Jul 21, 2026
@iloveeclipse
iloveeclipse merged commit 30b8bb2 into eclipse-platform:master Jul 21, 2026
18 checks passed
@iloveeclipse
iloveeclipse deleted the issue_2819 branch July 21, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Moving non-empty directory via drag and drop to linked folder is broken

2 participants