Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Unique model tags can cause valid extension-contributed action sets to be omitted.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Prevents initially visible legacy action sets from leaking into model-contributed perspectives.
Changes:
- Tracks tags added by perspective extensions.
- Adds regression coverage for model perspectives.
- Registers the test in the API suite.
File summaries
| File | Description |
|---|---|
WorkbenchPage.java |
Filters constructor-added action-set tags. |
ModelPerspectiveActionSetTest.java |
Tests action-set leakage. |
ApiTestSuite.java |
Adds the regression test. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
akurtakov
force-pushed
the
actionset-leak-into-model-perspectives
branch
from
September 15, 2026 19:03
4d29bd6 to
238fe12
Compare
akurtakov
force-pushed
the
actionset-leak-into-model-perspectives
branch
2 times, most recently
from
September 15, 2026 19:21
c81f769 to
52f0561
Compare
extendPerspectives() reads the perspectiveExtensions contributions into a scratch perspective and copies the resulting action set tags onto the real one. Constructing its ModeledPageLayout already tags that scratch perspective with every action set declared visible="true", so those were copied as well. This surfaced once model contributed perspectives became known to the PerspectiveRegistry and thus reached this code: a pure e4 application got the legacy action sets of every bundle it ships, appended to its trim as disabled tool items. Drop the seeded tags before reading the extensions so that only what the extension point contributes is taken over. Assisted-by: Anthropic Claude Code (claude-opus-5[1m])
akurtakov
force-pushed
the
actionset-leak-into-model-perspectives
branch
from
September 15, 2026 19:44
52f0561 to
7e5d528
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extendPerspectives() reads the perspectiveExtensions contributions into a
scratch perspective and copies the resulting action set tags onto the real
one. Constructing its ModeledPageLayout already tags that scratch perspective
with every action set declared visible="true", so those were copied as well.
This surfaced once model contributed perspectives became known to the
PerspectiveRegistry and thus reached this code: a pure e4 application got the
legacy action sets of every bundle it ships, appended to its trim as disabled
tool items.
Drop the seeded tags before reading the extensions so that only what the
extension point contributes is taken over.
Assisted-by: Anthropic Claude Code (claude-opus-5[1m])