Ask before closing projects nested below the selection - #4332
Open
vogella wants to merge 1 commit into
Open
Conversation
Contributor
vogella
force-pushed
the
close-nested-projects
branch
2 times, most recently
from
September 2, 2026 05:10
10e6921 to
e908070
Compare
Close Project closed exactly the selected projects, so a project that physically contains other projects left those open. The action now offers to close the nested projects too, in a dialog with "Close Selected Only" as the default, "Close Including Nested" and Cancel. A "Remember my decision" toggle stores the answer in a new workspace preference, shown next to the setting for opening referenced projects. Nothing is asked when no open project is nested below the selection. CloseUnrelatedProjectsAction opts out, it already confirms the projects it computes. Assisted-by: multiple AI agents and layers of automated tooling 🤖
vogella
force-pushed
the
close-nested-projects
branch
from
September 2, 2026 11:00
e908070 to
676931c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close Project closed exactly the selected projects, so closing a project that physically contains other projects, such as a Maven or Gradle root, left the nested modules open. The action now offers to close them too, with Close Selected Only as the default, Close Including Nested, and Cancel. A Remember my decision toggle stores the answer in a new workspace preference, listed next to the existing setting for opening referenced projects, so nobody has to answer the question on every close. Nothing is asked when no open project is nested below the selection, and Close Unrelated Projects keeps its own confirmation. A new test covers both remembered answers and the two cases that ask nothing.