Skip to content

Style the progress bar in the dark theme - #4319

Open
vogella wants to merge 1 commit into
eclipse-platform:masterfrom
vogella:dark-theme-progress-bar
Open

Style the progress bar in the dark theme#4319
vogella wants to merge 1 commit into
eclipse-platform:masterfrom
vogella:dark-theme-progress-bar

Conversation

@vogella

@vogella vogella commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

The progress bar had no rule of its own in the dark theme: only the ProgressIndicator around it was coloured, so the bar fell to the Composite > * catch-all on DARK_BACKGROUND and did not separate from the chrome.

Gives it #5A5F62 as the trough and LINK_COLOR as the fill. The .MPart copies live in e4-dark_partstyle.css because they only tie .MPart Composite > * > * on specificity and need to be imported after it.

Verified on Windows in the Progress view, the status line and the p2 install wizard: fill and trough resolve to the two colours at every fill level.

🤖 Generated with Claude Code

@vogella

vogella commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

Windows neu:

styled-progress-bars10 styled-progress-bars20

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Test Results

   858 files  +  286     858 suites  +286   40m 40s ⏱️ - 11m 27s
 8 308 tests ±    0   8 065 ✅ +    5  243 💤  -   5  0 ❌ ±0 
20 662 runs  +6 800  20 025 ✅ +6 618  637 💤 +182  0 ❌ ±0 

Results for commit 1ff130f. ± Comparison against base commit ee7ae1f.

♻️ This comment has been updated with latest results.

@BeckerWdf

Copy link
Copy Markdown
Member

how did it look before?

@vogella
vogella force-pushed the dark-theme-progress-bar branch 2 times, most recently from 80a0518 to 2e56600 Compare September 8, 2026 06:56
The bar had no rule of its own: only the ProgressIndicator around it was
coloured, so the bar fell to the 'Composite > *' catch-all on
DARK_BACKGROUND and did not separate from the chrome.

Give it #5A5F62 as the trough and LINK_COLOR as the fill. The '.MPart'
copies live in e4-dark_partstyle.css because they only tie
'.MPart Composite > * > *' on specificity and need to be imported after it.

Assisted-by: multiple AI agents and layers of automated tooling 🤖
@vogella
vogella force-pushed the dark-theme-progress-bar branch from 2e56600 to 1ff130f Compare September 9, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants