Fix/progress service run#4203
Open
fedejeanne wants to merge 2 commits into
Open
Conversation
It can be used to showcase a buggy behavior in IProgressService.run(). Contributes to eclipse-platform#4202 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…atform#4202 Fixes eclipse-platform#4202 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4202
This PR contains 2 commits: 1 that adds the
Progress Serviceview, making it easier to show the buggy behavior, and 1 that fixes the issue.How to test
You can use the newly added
ProgressServiceView:ProgressServiceView(Window > Show View > Other... > Progress Examples > Progress Service).Preferences > General— the view's checkboxstays in sync either way).
threshold (e.g. 3000 ms), click Run.
Expected behavior:
No progress dialog should appear.