Optional filter text autocomplete support in chevron pop up

[elsazac]

Refs : #194

This PR address one of the feature suggestion in #194.

This PR includes an autocomplete feature in the chevron popup filter, making it easier to navigate when too many editors are opened in the workbench. As the user types, matching editor names are suggested in the filter text area and the remaining part is auto-filled, improving speed and efficiency in locating editors.

This enhancement is implemented as an optional feature for the filter text in chevron pop up ie, users can enable or disable the autocomplete option based on their preference. A checkbox option to enable and disable the autocomplete behaviour is given in the Eclipse -> Settings -> General page. The feature is controlled through a new preference flag, ENABLE_AUTOCOMPLETE_IN_CHEVRON, stored under org.eclipse.ui.workbench. Users can enable or disable autocomplete in the Workbench Preferences, and when disabled, the chevron shows the normal standard filtering behaviour.

Key changes:

1. Introduced a new optional autocomplete behaviour in the chevron popup to provide suggestions and auto completion.
2. Normal text filtering is still available.
3. Added a checkbox in Preference page to let users enable or disable the autocomplete option depending upon their preference.
4. By default the option is disabled, but if the feature is to be enabled it can be done via Eclipse -> Settings -> General -> Enable autocomplete option in chevron popup

Optionalautocompleteoption.mov

[github-actions]

Test Results

   855 files  ±0     855 suites  ±0   1h 3m 17s ⏱️ + 2m 27s
 8 120 tests ±0   7 877 ✅ ±0  243 💤 ±0  0 ❌ ±0 
20 262 runs  ±0  19 608 ✅ ±0  654 💤 ±0  0 ❌ ±0 

Results for commit 18e06d4. ± Comparison against base commit ce4e10f.

♻️ This comment has been updated with latest results.

[elsazac]

@merks Would you be able to take a look at this?

[elsazac]

@merks Would you mind reviewing this PR when you have a chance?

[merks]

I'm concerned that the preference happens too quickly and not when the changes are applied by hitting Apply or OK. Please clarify the details around that.

[merks]

I wanted to actually test it...

One thing I realized is had no idea about with the "chevron poup" actually refers to. I also wondered why anyone would ever not want this, i.e., why an option (and one where the user is unlikely to map the label of the option to something concrete in the UI.

Maybe @iloveeclipse, @HeikoKlare, or @sratz have opinions about whether this should be an option on just be the new default behavior always?

It seems cool and convenient, but the behavior is not exactly what I expected. I.e., when I was in this state below, I though hitting enter would choose the auto-complete value:

But it chooses whatever is selected down below, which is not unreasonable, but somehow inconvenient because I don't actually know how to "choose" the autocompleted value. There seem to be no way which somehow detracts from the usefulness...

[iloveeclipse]

I've checked the feature and I think the extra code doesn't improve usability, it confuses more then it helps.

The (probably AI generated) feature desription says:

As the user types, matching editor names are suggested in the filter text area and the remaining part is auto-filled, improving speed and efficiency in locating editors.

Current behavior is that the popup list already filters the list and preselects first matching item "as the user types", so after typing few letters all what user needs is to hit "enter" - it is already as simple as it could be.

With the proposed extra code we also see the text for the already selected element in the text box, and that's it. Still hitting "enter" does same.

So what is the benefit of filling in the text in the text box? IMO this PR can be closed.

[elsazac]

Thanks @merks for testing this. apologies for the delayed response. I had been away for a while and am only now getting around to addressing everything.

and one where the user is unlikely to map the label of the option to something concrete in the UI.

I agree that the name "chevron popup" isn't very understandable from a user POV as many might not be even be familiar with the name. If you have a suggestion for a more relevant one, i can update that.

But it chooses whatever is selected down below, which is not unreasonable, but somehow inconvenient because I don't actually know how to "choose" the autocompleted value. There seem to be no way which somehow detracts from the usefulness...

What I had been doing was pressing the right arrow key to accept the autocomplete text first, and then pressing enter to get the item. I hadn't really considered the possibility of using enter directly to accept the autocomplete suggestion, but your comment made me realize that it makes sense and is probably what users would naturally expect. so I have updated the code accordingly. I would appreciate it if you could give the updated code another try. Thanks!