[GTK4] Wire menubar drop-downs by menu model, not position - #3587
Merged
akurtakov merged 1 commit intoSep 11, 2026
Merged
Conversation
akurtakov
force-pushed
the
gtk4-fix-menubar-popover-lookup
branch
from
September 11, 2026 20:59
88f73a8 to
bdb7322
Compare
Menu.connectDropDownMenuSignals paired the bar's child widgets with the item list positionally. It also runs from the model's "items-changed", i.e. in the middle of an item being created or disposed, when the two are out of step; a positional walk then wired a menu to its neighbour's popover, leaking the Menu and leaving submenus without their SWT.Show. Locate each drop-down's popover by its menu model with findNestedPopoverForModel instead, and drop the now unused findGtkPopoverMenuChild. Assisted-by: Anthropic Claude Code (claude-fable-5-1)
akurtakov
force-pushed
the
gtk4-fix-menubar-popover-lookup
branch
from
September 11, 2026 20:59
bdb7322 to
ef0af4a
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The timing-sensitive GTK4 regression needs automated coverage for mapped menu mutation and disposal.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates GTK4 menu-bar signal wiring to match popovers by menu model instead of child position.
Changes:
- Finds each submenu popover through its model.
- Removes the obsolete positional lookup helper.
- Prevents neighboring menus from receiving incorrect signal wiring.
File summaries
| File | Description |
|---|---|
Menu.java |
Reworks GTK4 drop-down popover discovery and removes unused traversal code. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Menu.connectDropDownMenuSignals paired the bar's child widgets with the item list positionally. It also runs from the model's "items-changed", i.e. in the middle of an item being created or disposed, when the two are out of step; a positional walk then wired a menu to its neighbour's popover, leaking the Menu and leaving submenus without their SWT.Show.
Locate each drop-down's popover by its menu model with findNestedPopoverForModel instead, and drop the now unused findGtkPopoverMenuChild.
Assisted-by: Anthropic Claude Code (claude-fable-5-1)