[Build] Cleanup github workflows and simplify test result publication - #3571
Conversation
8768a8f to
5ae4c27
Compare
| @@ -43,7 +47,7 @@ jobs: | |||
| fi | |||
|
|
|||
| check-jni-generator-consistency: | |||
There was a problem hiding this comment.
To make this a bit more efficient, we could also just merge the checks into one check-consistency job.
There was a problem hiding this comment.
Can you make one job report two different statuses ? One for javadoc and one for jni.
There was a problem hiding this comment.
There will be different error annotations on the job/check but there can only be one check/status in the box at the bottom of a PR (as far as I know).
But since in case of inconsistencies one has to click on the job anyway to see the details, I'd say that learning which consistency failed only after clicking on the status/job is IMO fine.
I think it's important to know that everything is consistent or not.
And since we might get more consistency checks e.g. with #3561, I'm not sure we want to grow the number of checks/status likewise.
There was a problem hiding this comment.
🟡 Changes recommended
The local-testing fallback can download artifacts from an unrelated workflow run.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Cleans up GitHub Actions workflows and streamlines test-result publication.
Changes:
- Removes the obsolete release workflow.
- Moves lightweight jobs to
ubuntu-slim. - Consolidates event uploads and simplifies artifact downloads.
File summaries
| File | Description |
|---|---|
.github/workflows/updateRelease.yml |
Removes the unused release workflow. |
.github/workflows/pr-checks.yml |
Uses slim runners with explicit Maven setup. |
.github/workflows/maven.yml |
Consolidates change detection and event upload. |
.github/workflows/junit.yml |
Simplifies platform discovery and artifact downloads. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| gh api $url > "$name.zip" | ||
| unzip -d "$name" "$name.zip" | ||
| done | ||
| gh run download ${{ github.event.workflow_run.id }} --repo ${{ github.repository }} \ |
There was a problem hiding this comment.
Please either derive the run ID from the supplied URL here or remove the artifacts_url local-testing path consistently.
Removed the local-testing path consistently since it's sufficiently simple to run all this in one's own fork.
- Remove unused updateRelease.yml. The called workflow was removed in favor of a Jenkins pipeline some time ago. - Apply other miscellaneous minor cleanups. - Simplify download of results in test results publication - Run lightweight tasks on ubuntu-slim runners
5ae4c27 to
b04d60e
Compare
|
The Jenkins build failure is unrelated, submitting. |
@jonahgraham since you have written a large majority of the latest state of test result publication, do you want to have a look at this?