Repository navigation
Gate historical orphan recovery by exhausted attempts, age and bounded batches - #65
Draft
echoomegaprime wants to merge 2 commits into
Conversation
…age and bounded batches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose (independent CertForge release-gate review)
Stacked on draft PR #64 at exact parent
e6b51c683c0027cab3ed446a26fdd614476a32c6; this is a minimal follow-up for historical-orphan recovery scope discovered in the independent #50/#49 review. It does not alter Swarm PR #16, the deployed CertForge service, production SQLite or enrolled runners.Safety changes
FAILED dispatch / BOUND reservation / QUEUED runnow requires exhausted attempts (d.attempts >= self.policy.max_dispatch_attempts), known pre-execution failure code (subscriber_worker_claim_deniedordispatch_attempts_exhausted), and a 24-hour stable-age cutoff.Verification (disposable FORGE checkout; no production changes)
e6b51c683c0027cab3ed446a26fdd614476a32c6; tested initial tree03980ad24ebdd00985b1a60d555fdd6abf17e975; final tree346c295485ed9b08458d25c946b6b75a2b671d95.test_dispatch_orphaned_runs.py,test_subscriber_migration_rollback.py,test_dispatch_orphan_audit_redaction.py, andtest_dispatch_orphan_batch_recovery.py.e0839e98bdd20bb6ae80c842cad50573efe04437and883e20ed87d5781e158bfd317be4f735f49f724f.Outstanding release gates
Parent PR #64 had passing hosted CI and CodeQL workflow job, but a failing GitHub Advanced Security CodeQL alert and misleading deployed Release Sentinel success. Security adjudication, deployed Sentinel fail-closed remediation, independent protected review, reconciled ancestry, authorized reversible two-phase admission and authentic enrolled-runner heartbeats are blocking. The Swarm target
f65935510f35b035536e08b6ae292cd821f02327is NOT_READY, lacking independently signed HAMMER production evidence and authentic distinct 40/40 participation.Do not merge or deploy on this PR alone; do not manually mutate historical reservations or billing rows. Tracking: CertForge #50, #51, PR #49, PR #52, PR #64, Sentinel PR #4.
Exact-head follow-up (2026-11-13)
Initial head
3fccacd327e060388478c63214ee15691db3ca37ran hosted CI: 736 passed / 3 failed. The failures were older audit/batch tests expecting unsafe automatic compensation of unknown failures or all five rows in a single transaction. That is an intentional policy behavior change, not evidence for weakening the guard. The tests were updated to assert unknown errors are held without compensation, no untrusted text reaches immutable audit, and cross-tenant orphan recovery is bounded 4 + 1 with exactly-once billing. Final draft head:1d15bdf4cb5db6ec120f2b8c05928f29361d8593, final tree346c295485ed9b08458d25c946b6b75a2b671d95, matching disposable FORGE checkout byte-for-byte. All 43 targeted regression tests passed at this final tree; the latest GitHub hosted CI and GHAS checks must be freshly evaluated on the final exact commit before review. No protected branch, live database or production service was changed.