Repository navigation
Conversation
…gs the action Keychain broadcasts get a 30 s deadline (10 min after the extension has answered a ping, so a user reading the prompt is not cut off), with a message to check the wallet before trying again. Closes #2125
…d tenant status - Each payment transfer in a transaction is recorded under its own key, so a second transfer in the same transaction is no longer skipped as a repeat. - Activating a subscription keeps a suspended tenant suspended. - Tenant names reserved by the platform cannot be created or claimed. Closes #2128
- HiveSigner sign-in accepts only an access token issued to this app for the account HiveSigner names. - Each login challenge is stored and used on its own, so starting a second login does not affect the first.
- Server routes that identify a user from a HiveSigner token accept only an access token issued to this app, for the account HiveSigner names. - The HiveSigner login callback completes only a login started in the same tab (one-time state value, safe under a double mount). - Base URLs written into links and metadata come from the request only for the site's own hosts; anything else uses the configured base.
- A new payment for a suspended tenant is acknowledged (credited, not published) instead of answering a retryable error. - Hosting sign-in keeps the access-token and account checks but accepts any app, since a blog may use its own HiveSigner app. - The login state value is kept per browser for 30 minutes, so a login that finishes in another tab completes; a stray callback no longer clears a pending one; Back after signing in does not open the login dialog. - The base URL drops a port taken from a request header.
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 17 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
PR Summary by QodoHarden sign-in and fix wallet and hosting payment edge cases
AI Description
Merge Risk
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94b01b13f3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (op[0] !== 'transfer' || op[1]?.to !== paymentAccount) return; | ||
| found.push({ key: found.length === 0 ? trxId : `${trxId}:${opIndex}`, transfer: op[1] }); |
There was a problem hiding this comment.
Preserve legacy payment keys when non-HBD transfers come first
When replaying a transaction processed before this change that contains a HIVE transfer followed by an HBD transfer to the payment account, the HBD payment is credited twice. Previously, processTransfer ignored the HIVE transfer without inserting a payment row, so the HBD transfer was recorded under the bare transaction ID. This helper instead assigns that bare ID to the ignored HIVE transfer and gives the HBD transfer a new suffixed key, bypassing both existing deduplication checks and extending the subscription again. Assign the legacy bare key to the first HBD transfer rather than the first transfer of any currency, and cover this mixed-currency replay case.
Useful? React with 👍 / 👎.
[Critical impact] The follow-up changes appear safe to merge; no blocking issues remain. SummaryThis PR hardens sign-in and fixes wallet waits and hosting payments. Both previous findings are addressed; no new actionable issues were found in the follow-up changes.
Reviews (2) · Last reviewed commit: "fix(hosting-api,web): replayed payments ..." · Reviewed by Greptile |
Code Review by Qodo
1. New payment parsing code loses type checking through any
|
…ng logins - The first HBD transfer in a transaction keeps the bare trx id, as the listener recorded it before, so a replay over older blocks finds its row. - Logins started in several tabs each complete (a few pending state values, 30 minutes each).
Sign-in hardening across web and hosting, plus self-hosted and hosting payment fixes.
Closes #2125, closes #2128
Self-hosted (#2125)
Hosting API
<trx>:<opIndex>.Web
Tests (written first, failing before the change)
apps/self-hosted/src/features/auth/utils/extension-broadcast-deadline.test.tsapps/self-hosted/hosting/api/src/payment-listener-multi-op.test.tsapps/self-hosted/hosting/api/src/payment-keeps-suspension.test.tsapps/self-hosted/hosting/api/src/routes/internal.test.ts(suspended case)apps/self-hosted/hosting/api/src/utils/reserved-tenant-names.test.tsapps/self-hosted/hosting/api/src/routes/auth-challenge-per-request.test.tsapps/self-hosted/hosting/api/src/routes/auth-handoff.test.ts(token kinds)apps/web/src/specs/server/hivesigner-verify.spec.tsapps/web/src/specs/app/auth-login-state.spec.tsxapps/web/src/specs/utils/server-app-base.spec.tsGreen after: web 6936, self-hosted 1080 plus its build, hosting API 487 plus
tsc,pnpm typecheck,pnpm lint, and the script audits with--fail.Before deploy
HIVESIGNER_CLIENT_ID, where it is set server-side, is the same app id the login uses (defaultecency.app).