Skip to content

Silly difference: Backends have inversed contrasts#647

Merged
strengejacke merged 7 commits into
mainfrom
strengejacke/issue645
Jul 19, 2026
Merged

Silly difference: Backends have inversed contrasts#647
strengejacke merged 7 commits into
mainfrom
strengejacke/issue645

Conversation

@strengejacke

@strengejacke strengejacke commented Jul 19, 2026

Copy link
Copy Markdown
Member

Fixes #645

  • Tests need to be updated

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request changes the default value of the comparison argument in get_emcontrasts() from "pairwise" to "revpairwise" to ensure consistent contrast signs with the "marginaleffects" backend, alongside documentation updates and code reformatting. However, the reviewer noted that this change is currently overridden and ineffective because estimate_contrasts.default() still defaults to "pairwise". To fix this, the default in estimate_contrasts.default() should be set to NULL and resolved dynamically, and the corresponding tests should be updated.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread R/get_emcontrasts.R
Comment thread R/estimate_contrasts.R
@strengejacke
strengejacke merged commit 375c5ca into main Jul 19, 2026
12 of 20 checks passed
@strengejacke
strengejacke deleted the strengejacke/issue645 branch July 19, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Silly difference: Backends have inversed contrasts

1 participant