Silly difference: Backends have inversed contrasts#647
Conversation
There was a problem hiding this comment.
Code Review
This pull request changes the default value of the comparison argument in get_emcontrasts() from "pairwise" to "revpairwise" to ensure consistent contrast signs with the "marginaleffects" backend, alongside documentation updates and code reformatting. However, the reviewer noted that this change is currently overridden and ineffective because estimate_contrasts.default() still defaults to "pairwise". To fix this, the default in estimate_contrasts.default() should be set to NULL and resolved dynamically, and the corresponding tests should be updated.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Fixes #645