fix: renew standalone certificates with nginx running - #163
Open
ermolaev-bst wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔀 Description of Change
Improvement in Certificate Renewal Process
The installation script has been made more robust by incorporating checks to ensure other running processes are not interrupted during the certificate renewal using ACME HTTP-01 challenge. These changes streamline the certificate renewal process, improve error messages in case the renewal fails, and allow better management when working with different certificate configurations.
Enhancements in English Language Messaging
Added a clearer and more user-friendly error message in English for situations when the certificate renewal fails. This new addition will improve user understanding and troubleshooting attempts.
Additions to Russian Language Messaging
To maintain relevance with the updated English messaging, a new error message has also been added in Russian. This ensures an equal level of clarity and usability for Russian speaking users during certificate renewal issues.
Fixes Certbot renewal for HTTP-01 standalone certificates when
remnawave-nginxalready owns port 80.What was wrong
/opt/remnawavepath, which is invalid for node-only installations under/opt/remnanode;docker compose down remnawave-nginxis not a valid service-scoped Compose command;Changes
remnawave-nginx;Verification
bash -n install_remnawave.sh src/lang/en.sh src/lang/ru.shgit diff --checkcertbot renew --dry-run --no-random-sleep-on-renew