SDSTOR-25274: improve stability of scrubber tests - #458
Merged
JacksonYao287 merged 1 commit intoAug 25, 2026
Conversation
JacksonYao287
commented
Aug 24, 2026
| # GC tests | ||
| add_test(NAME FetchDataWithOriginatorGC | ||
| COMMAND homestore_test_dynamic --executor immediate --config_path ./ | ||
| --override_config hs_backend_config.enable_gc=true |
Member
Author
There was a problem hiding this comment.
gc is enabled as default, so remove this
| cur_batch_blob_count_ = 0; | ||
| } | ||
| cur_obj_id = id; | ||
| LOGD("Advanced resync cursor: pg={}, obj={}, shard_index={}, blob_index={}", pg_id, id.to_string(), |
Member
Author
There was a problem hiding this comment.
all the changes in this file are all format changes made by clang-format, no logic change
| m_snp_rcv_handler = std::make_unique< HSHomeObject::SnapshotReceiveHandler >(*home_object_, r_dev); | ||
| if (m_snp_rcv_handler->load_prev_context_and_metrics()) { | ||
| LOGI("Reloaded resync receiver context: lsn={}, pg={}, next_shard=0x{:x}", | ||
| m_snp_rcv_handler->get_context_lsn(), |
Member
Author
There was a problem hiding this comment.
only format changes, too.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stable/v4.x #458 +/- ##
==============================================
Coverage ? 54.37%
==============================================
Files ? 39
Lines ? 6830
Branches ? 940
==============================================
Hits ? 3714
Misses ? 2716
Partials ? 400 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Besroy
approved these changes
Aug 25, 2026
Besroy
left a comment
Besroy
left a comment
Contributor
There was a problem hiding this comment.
Lets merge and trigger a new image build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scrubber UT will fail if leader switch occurs when scrubber UT is on going. This PR handles the case to improve the stability of scrubber UT