Repository navigation
Conversation
…screens
Two issues found while testing against OpenCode 1.18.34:
1. Permission prompts never appeared for tool calls. The server emits
permission.v2.asked events with {id, sessionID, action, resources},
but the SSE handler only matched the legacy permission.asked format.
Added a normalization layer (src/lib/permissions.ts) that converts
both protocol generations into a single internal model, and updated
the event handler to process v2 asked/replied events. Pending
permissions are also reconciled on SSE reconnect and app foreground
so a missed event doesn't leave the session stuck.
2. Keyboard covered input fields on the connection add/edit screens.
The chat screen already used KeyboardAvoidingView with
behavior="padding", but the connection screens used a bare ScrollView.
On Android 15+ edge-to-edge, adjustResize is a no-op so the keyboard
stays on top of the content. Wrapped both connection screens in the
same KeyboardAvoidingView pattern.
Includes PR dzianisv#210 (IME insets) which was already open.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two issues found while testing against OpenCode 1.18.34:
1. Permission prompts never appeared for tool calls
The server emits
permission.v2.askedevents with{id, sessionID, action, resources}, but the SSE handler only matched the legacypermission.askedformat. When a tool needed approval, the session would just sit there waiting — no prompt, no way to approve.Added a normalization layer (
src/lib/permissions.ts) that converts both protocol generations into a single internal model, and updated the event handler to process v2 asked/replied events. Pending permissions are also reconciled on SSE reconnect and app foreground so a missed event doesn't leave the session stuck.2. Keyboard covered input fields on the connection add/edit screens
The chat screen already used
KeyboardAvoidingViewwithbehavior="padding", but the connection screens used a bareScrollView. On Android 15+ edge-to-edge,adjustResizeis a no-op so the keyboard stays on top of the content. Wrapped both connection screens in the sameKeyboardAvoidingViewpattern.Includes
Cherry-picks PR #210 (IME insets fix) which was still open.
Testing