Skip to content

fix(cd): tags/branches named vX.Y.Z, not vfunera-core@X.Y.Z #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dynamder merged 1 commit into from
Aug 19, 2026
Merged

fix(cd): tags/branches named vX.Y.Z, not vfunera-core@X.Y.Z #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,9 @@ jobs:
- name: Open release PR and merge
if: ${{ !inputs.skip_bump }}
run: |
VERSION="$(cargo pkgid -p funera-core | sed 's/.*#//')"
# `cargo pkgid` yields `funera-core@X.Y.Z`; extract the bare version
# so tags/branches are named vX.Y.Z (no `vfunera-core@` prefix).
VERSION="$(cargo metadata --no-deps --format-version 1 | jq -r '.packages[] | select(.name == "funera-core") | .version')"
BRANCH="release/v${VERSION}"
git push origin "HEAD:${BRANCH}"
PR_URL="$(gh pr create --base main --head "${BRANCH}" \
Expand All @@ -97,7 +99,7 @@ jobs:
- name: Push tag
if: ${{ !inputs.skip_bump }}
run: |
VERSION="$(cargo pkgid -p funera-core | sed 's/.*#//')"
VERSION="$(cargo metadata --no-deps --format-version 1 | jq -r '.packages[] | select(.name == "funera-core") | .version')"
git push origin "refs/tags/v${VERSION}"

- name: Publish funera_core
Expand All @@ -120,7 +122,7 @@ jobs:

- name: Create GitHub Release
run: |
VERSION=$(cargo pkgid -p funera-core | sed 's/.*#//')
VERSION="$(cargo metadata --no-deps --format-version 1 | jq -r '.packages[] | select(.name == "funera-core") | .version')"
git fetch --tags
gh release create "v$VERSION" --generate-notes
env:
Expand Down
Loading