Skip to content

Don't serialize the states of intermediate variables - #598

Closed
arcondello wants to merge 48 commits into
dwavesystems:0.8.xfrom
arcondello:breaking-change/all-nodes-are-deterministic
Closed

Don't serialize the states of intermediate variables#598
arcondello wants to merge 48 commits into
dwavesystems:0.8.xfrom
arcondello:breaking-change/all-nodes-are-deterministic

Conversation

@arcondello

Copy link
Copy Markdown
Member

This is a backwards compatibility breaking change.

Don't serialize the states of intermediate variables. This simplifies some aspects of serialization significantly. Models serialized before this change will have the states of intermediate variables ignored.

AI Generation Disclosure

No AI used.

arcondello and others added 6 commits August 4, 2026 15:53
Handle the case that decisions are not the first N of nodes_
Handle the case that decisions are not the first N of nodes_.
…mutation

Add Graph::pop_decision() and Graph::swap_decisions() methods
@arcondello arcondello added the enhancement New feature or request label Aug 6, 2026
@smharwood

Copy link
Copy Markdown
Contributor

I've tried serializing and loading a model with different versions and they all act as expected.

Though, I keep wondering if there is a test we can add - for instance, commit a small model to the repo that was serialized with the old behavior and make sure it can be loaded with the latest version?

@arcondello
arcondello force-pushed the breaking-change/all-nodes-are-deterministic branch from fac3973 to cbb69a5 Compare August 11, 2026 21:58
hurdwave and others added 7 commits August 11, 2026 15:21
…tsets-const-state-index

Add const overload for DisjointBitSetsNode::get_containing_set_index()
Previously we made a malformed Symbol. This uses a default
Python mechanism.
Use `PyCapsule` for creating `Symbol`s from `Node*`s
…heck_for_checkpointing

Add additional ``BinaryNode`` checkpoint tests
@arcondello
arcondello force-pushed the breaking-change/all-nodes-are-deterministic branch from cbb69a5 to 3987f10 Compare August 12, 2026 23:53
@arcondello

Copy link
Copy Markdown
Member Author

Closing in favour of #611

@arcondello arcondello closed this Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants