Skip to content

Split MariaDB native execution tests across existing parity shards - #1041

Closed
rmcdaniel wants to merge 2 commits into
mainfrom
perf/server-mariadb-parity-shards
Closed

rmcdaniel wants to merge 2 commits into
mainfrom
perf/server-mariadb-parity-shards

Conversation

@rmcdaniel

@rmcdaniel rmcdaniel commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

The unsharded MariaDB native execution lane was the final check holding Server #1036. Its runner steps took 22m28s; the later provider terminal-status delay is separate. Both MySQL labels already split the same execution suite across two parts.

Apply that existing two-part matrix to MariaDB, preserving every execution test once and keeping native database/TLS checks in their original part. Image pins, resource limits, test commands and two test threads are preserved. Retain the complete listed-test inventory and each shard's exact selection under the existing artifact limits. A failing list pipeline now refuses execution even if it emits partial output.

Validation: 48 part/artifact controls pass, including exact union/no-duplication/odd-list checks, real shell command selection with a fake Cargo, partial-output failure controls, byte-exact retained inventories and explicit truncation. The full repository isolation scan, whitespace and secret/private-path checks pass. Current ordinary CI will supply real shard results, selected-test inventories and timings before improvement is claimed. The original #1036 baseline artifact is authenticated and reports 727 passing tests plus one ignored test, but retains only a 64-KiB execution-log tail and no selection list; that limit is explicit.

#1036's original run and queue are untouched. This branch will refresh over its actual accepted main before integration. Related pacing record: #325 (comment) .

@rmcdaniel

Copy link
Copy Markdown
Member Author

Normal successor 66a2b0bfc7c21b696020feb3c4d27897892bef61 / tree 30f88451b9bd845799eace08a19c783e60643502 adds the missing observed coverage evidence and a list-failure guard.

The baseline artifact 13446179855 was independently downloaded and its ZIP SHA-256 matched the provider digest f3a7e72fe75a5aa457e2e390a99678a00347700ca9499062ffdd8298d46a8ee2. It binds normal PR merge 6f12c679 and reports 727 passing execution tests plus one ignored, but its execution output is an explicit 64-KiB tail and the source selection file was omitted. No full baseline selection inventory is claimed.

The successor records the full byte-sorted listed-test names with tee, retains that list and each selected shard file through the existing bounded summary, and enables pipefail before selection. Inert partial-output/exit-7 controls prove that neither shard runs a partial execution suite or final build when listing fails. All 48 focused part/artifact tests, the full isolation scan and whitespace/secret checks pass. The fresh changed-head ordinary run owns the next real pair-of-shards and complete-union/timing evidence; historical checks are not relabeled.

@sonarqubecloud

sonarqubecloud Bot commented Nov 5, 2026

Copy link
Copy Markdown

@rmcdaniel

Copy link
Copy Markdown
Member Author

The two CI pacing commits are now preserved by normal merge in active #1036 head 22ef3f86a44b5331056b97aa0e8e3c6627e83240. Closing this duplicate PR avoids an additional integration train; source acceptance remains pending on #1036's fresh combined-head checks. This branch stays preserved until that actual integration and cleanup.

The original changed-source run 42099885143 already supplies bounded measurement: MariaDB native parts succeeded in 12m33s and 11m07s, compared with the prior unsharded 22m28s. Both artifact ZIP hashes match their provider digests; complete inventories prove 728 listed tests, two disjoint selections of 364 and no omission. Full execution report retention for the -b part was still missing in this attempt and is corrected in #1036. Other pending/terminal workflow contexts are not claimed as acceptance or transferred to another head.

#1036 also corrects the independent frozen-PHP SQLite cleanup contention discovered by its original failed queue group, while preserving exact assertions and all fixture coverage. That original failure remains failed. No manual rerun, new native experiment or publication effect is involved.

@rmcdaniel rmcdaniel closed this Nov 5, 2026
@rmcdaniel
rmcdaniel deleted the perf/server-mariadb-parity-shards branch November 5, 2026 21:32
@rmcdaniel

Copy link
Copy Markdown
Member Author

The carried CI pacing source is now in accepted Server main through #1036, actual merge cf069f6396f29e8f90563a6d75108779e30c3a2a / tree 805a31ff. Its original corrected queue and all five actual-main workflows passed. This PR remains closed as carried, not independently merged or fully qualified. The pacing branch's exact source head 66a2b0bf is an ancestor of accepted main; its clean worktree and local/remote branch are now removed, with independent remote 404. The measured split/coverage evidence remains on #1036. No CI coverage was dropped and no runtime-performance or publishing result is inferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant