Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pending workflow's generator currently finalizes before a query observes its state.
finallyand nested context exits change values from waiting to cleanup, and disposal can emit workflow logs. This is the accepted lifecycle defect in #178.This tests-first draft adds 20 failing controls across activity, timer, condition and child suspensions: public/prepared queries, asynchronous query consumption, mutable result aliases, nested context managers, cancellation shields and discarded-replay logging. They reproduce on current main without product changes.
Implementation will give each replay bounded ownership through query/update consumption, detach observable results before disposal, and distinguish discarded SDK effects from actual workflow exit. Yielded-finally disposal, real success/failure/cancellation cleanup, cold replay and affected worker paths remain required. No frame mutation, global unraisable hook, unbounded generator cache, version change or release is included in this checkpoint. The independently qualified #175 and #225 candidates are unchanged.