Skip to content

Validate selected documentation presentation assets - #317

Merged
rmcdaniel merged 1 commit into
mainfrom
fix/315-presentation-style-validation
Nov 5, 2026
Merged

rmcdaniel merged 1 commit into
mainfrom
fix/315-presentation-style-validation

Conversation

@rmcdaniel

Copy link
Copy Markdown
Member

The stable 3.9.4 preview renders the selected One Identity template but its asset checker reads CSS and JavaScript from the published SDK checkout, so the build refuses correctly rendered assets. Use DOCS_TEMPLATE_DIRECTORY for those two presentation assets, retaining SDK-owned analytics and the existing exact-byte checks.

Five focused regression groups cover distinct presentation assets, stale assets, missing-template refusal, the unchanged default and SDK-owned analytics. The original checker fails three groups; the correction passes all five and validates the existing stable render (17 portal + 376 API pages). Both source CI and the build-only workflow run the controls.

Follow-up for #315 after build-only run 42127296942 failed with deployment skipped. This changes source validation only; publication-path acceptance remains separate.

@rmcdaniel rmcdaniel added the agent:sdk-php Work done by the sdk-php repo agent label Nov 5, 2026
@sonarqubecloud

sonarqubecloud Bot commented Nov 5, 2026

Copy link
Copy Markdown

@rmcdaniel
rmcdaniel marked this pull request as ready for review November 5, 2026 23:15
@rmcdaniel
rmcdaniel merged commit 260af3c into main Nov 5, 2026
42 checks passed
@rmcdaniel
rmcdaniel deleted the fix/315-presentation-style-validation branch November 5, 2026 23:27
@rmcdaniel

Copy link
Copy Markdown
Member Author

Normal merge verified independently as 260af3c, tree 18d65d01dbdc0888921532e09ab9ecc5eed12278, ordered parents a4315bcd + reviewed 38e8b109. Git and GitHub agree; the reviewed and merged trees match. Product source, examples, configuration, resources and Composer identity are unchanged.

PR checks are terminal 42 = 41 success + one intended skip; direct Sonar has no open findings. The historical browser cell passed without a rerun, although its dependency installation consumed 11m42s. Resulting main is terminal 42 = 40 success + two intended skips. Main CI passed. Portal build passed with deployment skipped. Live audit remains SDK/docs source 6a821568db5c72983bd3990fe27c7990f092db12, SHA256 43c0159fc3ee9317a32e644e20d61d47d2fbf64d23194efe7b8e1f2b86514cd1.

The exact owned remote head 38e8b109 was merged, unchanged and had no dependent open PR. Cleanup is complete; Git transport is empty and GitHub returns 404. The separate browser-source work is preserved on #318, draft/NONPASS pending the shared closure, and is not included in this acceptance.

Corrected stable build-only candidate 42130196926 uses this accepted workflow, published tag 3.9.4, unchanged SDK/docs source 6a821568, presentation a4315bcd, and build_only=true. It is rendering/source evidence only. Original failed run 42127296942 is retained. Actual publication stays held on its central setup/browser qualification and adoption boundaries; no deployment, installed/runtime or release result is claimed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:sdk-php Work done by the sdk-php repo agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant