Repository navigation
Bound failure reports within encoded request budgets - #217
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oversized PHP failure reports could exceed the published request limit and strand failure delivery. Published SDK 3.5.0 now bounds the UTF-8 message to 62 KiB, stack to 128 KiB, combined serialized details/diagnostics to 64 KiB and complete encoded request to 1 MiB, respecting lower known transport limits. Markers and escaping count. Failure type, retry flags/delay and original claim identity stay exact; impossible fixed content refuses explicitly. Whole Avro values remain whole or are explicitly omitted with bounded diagnostics. Initial local execution, persisted history and cold replay see the same bounded failure.
Delivered in published PHP SDK 3.5.0, immutable source
61fdd37f3afa5e6642249edc439cf656e3a65462, whole tree177f88a2176732f1580300a493d509e63e2a9c71through #217. Every applicable candidate and independent main gate passed; final direct Sonar review has zero open/confirmed findings.Normal Composer installation uses the registry dist at that exact source, without a path repository or source overlay. All 190 installed source files, plus the two release/quickstart manifests, match committed bytes. The installed SDK identifies itself as
durable-workflow-php/3.5.0.The unchanged installed delivery recipe passes all 13 actual cases on each of published Server 2.11.0 / SQLite and MySQL 8.0.46: message, stack, combined metadata, escaping, whole details, lower message/details limits, unchanged small reports, local execution/cold replay, cooperative worker, retry semantics, workflow-task failure and terminal workflow failure. Original per-case 30-second budgets remain unchanged. Each PHP cohort records 13 runs, 35 tasks, 11 activity executions and 74 history events. Separate recording PSR-18 controls bound a 3,145,728-byte original message to 63,488 bytes and actual encoded activity/workflow-task requests to 63,712 / 63,697 bytes while preserving original claim/type/retry authority.
Both API and queue roles exited 0 after explicit SIGTERM, without OOM. Both task databases, storage volumes and networks are removed. Earlier permission/identity fixture mistakes and the separately admitted Rust credential-role refusals remain recorded as unsuccessful preparations, not PHP SDK defects or rescued originals.
This completes the PHP SDK issue. Shared #225 remains open for the other SDKs, receiver-side storage/visibility follow-through and documentation. No automatic consumer pin, Server image or native adoption is claimed. The underlying derived timeline correction is separately published in Workflow 2.12.0 and still requires its affected image/consumer acceptance.
Earlier source qualification, corpus controls, PHPStan, full-suite results and failed originals remain in the original receipt. Metrics, profiling and child handles remain separate.