Repository navigation
Conversation
|
Member
Author
|
The complete source is delivered through merged #270 at 910f928 / whole tree ddbea538b1faf41a5c091641b8de71fcfe118357. Its exact bd5a08b candidate passes all 28 checks, including native amd64/arm64 root-image/browser/workflow qualification and all SDK originals. This supersedes the separate merge of this draft; closing it as delivered through #270. Publication and installed acceptance remain open on #271 and shared #237, with main image run 39848751833 still pending. Earlier failed observations remain failed on their original sources. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Verify production image inputs and effective trust
Refs #271 and durable-workflow/.github#237. This changes the root application image. Its final
cb3b9c30source is incorporated in combined PR #270, which will deliver both production and development fixes. Keep this draft unmerged; close it as delivered after the combined source qualifies and merges.tls.getCACertificates('default')before npm, after copying the runtime into the final image, and after browser installation. This includes configured extra/system roots, rather than inspecting only the bundled snapshot. TLS verification must remain enabled.Focused results: all three new immutable-input/order controls fail on the unchanged Dockerfile; the final correction passes three tests / 22 assertions. On the exact pinned Node input, all five process controls pass, including blocked extra/default roots, an empty default store and disabled verification. The real default store has 116 roots / zero blocked subjects. The public PEM fixture is synthetic; no private key is committed. The locked frontend installs all 87 packages and builds successfully with lifecycle scripts disabled.
Component source
45f108c17c1b429bd4fd55417d8c1fe59328ed37, whole tree8c642ee06d4acc92f6ac2bb099a6e6549b0e5d9a, has cold image run 39829977835 passing both native amd64 and arm64 jobs, including copied-runtime trust, browser startup, embedded workflows and teardown. Each job verifies the built platform and exact checkout revision label. The amd64 image issha256:f603d2107f39d49f7dd9f2be225dc8d1f786cda7e003aece23d87ce4686c16b0, labelled with synthetic checkout2cbda352ec4a457670c1bfb0920e8d1e3f37a345. Finalcb3b9c30restores the existing required status name as the aggregate over both architectures. Combined #270 must qualify its own complete tree.The initial candidate's Sonar failure remains recorded. The final source fixes npm lifecycle-script execution, generic exception handling and Docker ordering findings. The three readable-tag-plus-digest findings are accepted individually because the reviewed digests make these inputs immutable; no quality profile or threshold changed. Its Sonar passes with zero OPEN/CONFIRMED findings. Cancellation requests for optional unchanged SDK scenarios were not treated as proof of completed cancellation. The required source and image jobs were preserved; current combined results are recorded on #270.
Draft, delivered through #270 after its independent qualification. The cross-repository CI trust rollout remains open.