Repository navigation
Disable install lifecycle hooks in shared CI tooling - #210
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Use
npm ci --ignore-scriptsin the shared contract workflow and the conditional Rust documentation visual workflow. Both use the existing exact lockfile; the visual workflow already selects an explicitly packaged Chromium runtime, so dependency lifecycle hooks are unnecessary.This addresses the two actionable
githubactions:S6505findingsAaFA6dSyRifDd95mErWVandAaFA6dSlRifDd95mErWOunder #187. No package, lockfile, rule, threshold, profile or scan exclusion changes. No SDK/runtime/shared fixture behavior change.Verification
The actual Node24 locked installation passes: twenty installed packages, twenty-one audited, zero reported advisories. Both Node syntax checks pass with lifecycle scripts disabled. Local browser acceptance remains unqualified: Alpine cannot launch the packaged glibc Chromium (
spawn ENOENT); the separate cached Debian image lackslibnspr4.soand was stopped after confirming that setup failure (exit137, not graceful shutdown). No browser/runtime/assertion source was changed to bypass either result.All three exact-candidate checks PASS, including the hosted Ubuntu shared contracts/browser suite and Sonar. Direct API readback has gate OK, ignored conditions false, zero OPEN/CONFIRMED PR issues and 0% new duplication under the unchanged 3% threshold. Candidate
8cbfad90d189b8e3d70d39d122c89c68070d9c1band syntheticc2f53614share whole tree6e4d92ea9737c4b8cc2b08db108147444e7ba929. Only the two workflow command lines differ from main.Merged at
b2d9101c1e959abe505b846c793b2057faf8202f, with the same reviewed whole tree. All three independent fresh-main checks PASS, including shared contracts/browser and Sonar. Main analysisbc9f3f36-e877-4a06-8b44-55abbe939b20names this exact revision. Both original hook findings are automatically CLOSED / FIXED at 19:49:39 UTC on October 19, confirmed individually through the API. Historical findings are not declared resolved by a passing new-code gate. The completed source worktree and local/remote head branches are removed; local dependency/browser bulk was already retired.