Scope the deploy build to duo-universal-sdk so it builds on JDK 11 - #71
Merged
Merged
Conversation
AaronAtDuo
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
-pl duo-universal-sdkto theBuild with MavenandGenerate sbom outputstepsof the deploy workflow, so the root reactor no longer builds
duo-example.Motivation and Context
The 1.4.0 deploy failed at
Build with Maven:The workflow sets up JDK 11 and runs an unscoped
mvn -B package, which builds allthree reactor entries. #69 made
duo-examplerequire Java 17 (Spring Boot 3.x) andsplit CI into separate
-pl duo-universal-sdk(Java 8/11/17/21) and-pl duo-example -am(Java 17/21) jobs — but did not updatemaven-deploy.yml,leaving it as the only place still assuming both modules build under one JDK.
duo-exampleis never published, so it has no place in the deploy build.JDK 11 is deliberately kept rather than raised: the SDK sets
maven.compiler.source/targetto 1.8 rather than--release 8, so building on JDK 17would compile against Java 17's class library while emitting Java 8 bytecode, risking
runtime failures for the Java 8 users CI still tests.
How Has This Been Tested?
In the failing run itself,
duo-universal-sdkbuilt successfully on JDK 11 (87 testsgreen, both jars produced) before
duo-examplefailed — so removing it from the reactorremoves the only failing unit.
Locally,
mvn -B package -pl duo-universal-sdkandmvn org.cyclonedx:cyclonedx-maven-plugin:makeBom -pl duo-universal-sdkboth pass, andthe SBOM lands at
duo-universal-sdk/target/cyclonedx-sbom.json— the path thefollowing
mvexpects. CI already runsmvn -P release package -pl duo-universal-sdkgreen on Java 11.
Note that CI cannot exercise this change:
maven-deploy.ymlisworkflow_dispatch-only,so a green PR proves nothing here. The real verification is dispatching the workflow
after merge — against
main, since the1.4.0tag still carries the broken file.Types of Changes