Skip to content

Scope the deploy build to duo-universal-sdk so it builds on JDK 11 - #71

Merged
mihir-pradhan merged 1 commit into
mainfrom
fix_deploy_workflow_module_scope
Sep 16, 2026
Merged

mihir-pradhan merged 1 commit into
mainfrom
fix_deploy_workflow_module_scope

Conversation

@mihir-pradhan

@mihir-pradhan mihir-pradhan commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Description

Adds -pl duo-universal-sdk to the Build with Maven and Generate sbom output steps
of the deploy workflow, so the root reactor no longer builds duo-example.

Motivation and Context

The 1.4.0 deploy failed at Build with Maven:

Failed to execute goal maven-compiler-plugin:3.13.0:compile on project duo-example:
Fatal error compiling: error: release version 17 not supported

The workflow sets up JDK 11 and runs an unscoped mvn -B package, which builds all
three reactor entries. #69 made duo-example require Java 17 (Spring Boot 3.x) and
split CI into separate -pl duo-universal-sdk (Java 8/11/17/21) and
-pl duo-example -am (Java 17/21) jobs — but did not update maven-deploy.yml,
leaving it as the only place still assuming both modules build under one JDK.
duo-example is never published, so it has no place in the deploy build.

JDK 11 is deliberately kept rather than raised: the SDK sets
maven.compiler.source/target to 1.8 rather than --release 8, so building on JDK 17
would compile against Java 17's class library while emitting Java 8 bytecode, risking
runtime failures for the Java 8 users CI still tests.

How Has This Been Tested?

In the failing run itself, duo-universal-sdk built successfully on JDK 11 (87 tests
green, both jars produced) before duo-example failed — so removing it from the reactor
removes the only failing unit.

Locally, mvn -B package -pl duo-universal-sdk and
mvn org.cyclonedx:cyclonedx-maven-plugin:makeBom -pl duo-universal-sdk both pass, and
the SBOM lands at duo-universal-sdk/target/cyclonedx-sbom.json — the path the
following mv expects. CI already runs mvn -P release package -pl duo-universal-sdk
green on Java 11.

Note that CI cannot exercise this change: maven-deploy.yml is workflow_dispatch-only,
so a green PR proves nothing here. The real verification is dispatching the workflow
after merge — against main, since the 1.4.0 tag still carries the broken file.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@mihir-pradhan
mihir-pradhan merged commit c87e613 into main Sep 16, 2026
9 checks passed
@mihir-pradhan
mihir-pradhan deleted the fix_deploy_workflow_module_scope branch September 16, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants