Skip to content

Possible breaking change in certificate pinning in v1.4.0 #73

Description

@philsmart

It looks to me that v1.4.0 has introduced a breaking change (for a minor version) to the Client Builder API for setting pinned certificates:

public Builder setCACerts(String[] userCaCerts) {

SetCACerts used to accept public key pins in the String list, and now requires PEM-encoded certifcates?

So this can fail at runtime when supplied the old style pins.

If you agree, I am not sure if you'd want to revert that, add a new method for the new trust store mechanism, or document the migration in the release notes.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions