Skip to content

Exit through an injectable kernel; add Launcher (1/4 extensibility API) - #171

Closed
kigster wants to merge 8 commits into
dry-rb:mainfrom
kigster:main
Closed

kigster wants to merge 8 commits into
dry-rb:mainfrom
kigster:main

Conversation

@kigster

@kigster kigster commented Oct 7, 2026

Copy link
Copy Markdown

Proposal 1 of 4 in the dry-cli plugin-hooks series.

Upstream issue/forum thread: pending (per CONTRIBUTING.md this is discussed on the forum before going to dry-rb).

Summary

CLI exits go through an injectable kernel, and a Launcher runs a CLI with Aruba's in-process signature.

 Dry::CLI#call(arguments:, stdout:, stderr:, stdin:, kernel: Kernel)
   perform_registry / perform_command
     parse
     help           → raise Halt(0)
     error          → raise Halt(1)
     spell_checker  → raise Halt(1)
   rescue Halt      → kernel.exit(status)
   rescue Signal    → kernel.exit(128 + signo)

Explanation

  • Halt is private. It exists because a test kernel's exit returns: without it, execution would fall through the help screen into code expecting a parsed command.

  • kernel: is an auto_initialize keyword (Free up #initialize for command subclasses #167), so Command#kernel is set before #initialize and never reaches it. Private Command#exit goes through it.

Launcher

Launcher is an intermediate class that swaps out standard streams (stdin, stdout, stderr, and additionally, Kernel) so that in tests the streams could be replaced with StringIO, and Kernel.exit be a no-op.

This allows using another gem calleed aruba for proper CLI integration testing of the command, except without the penalty of a fork(). Given this type of Launcher pattern, Aruba is able to use it to drive the gem in a single process, making the tests much much faster.

Example on how to configure Aruba

MyApp::Launcher = Dry::CLI::Launcher[MyApp::Commands]   
MyApp::Launcher.new(ARGV).execute!

# spec/spec_helper.rb
Aruba.configure do |config|
  config.command_launcher = :in_process
  config.main_class       = MyApp::Launcher
end
  • Launcher[target, stdin:, stdout:, stderr:, kernel:] pins defaults for .new(argv); unpinned ones take the globals when the launcher is created. Aruba passes all five, so its StringIOs win.

  • #execute! exits 0 unless the CLI already exited; exceptions propagate. No global stream swapping.

Evidence

  • Before: Dry.CLI(registry).call(arguments: ["x", "-h"], kernel: fake) → NoMethodError (no kernel:); in-process Aruba runs end the test process on exit.

  • After: spec/unit/dry/cli/kernel_spec.rb (14), launcher_spec.rb (14), spec/integration/launcher_spec.rb (3, real Aruba in-process). Full suite: 631 examples, 0 failures; rubocop clean.

Notes

  • Adds a test dependency on aruba gem

See

Blog Post on testing CLI Gems with Aruba

Dry::CLI#call and Command.new take `kernel:`, defaulting to Kernel. Help,
errors and typos stop the CLI by raising a private Halt, which #call turns
into kernel.exit, so a kernel whose exit returns (as Aruba's does) still
stops the CLI. A command's own `exit` goes through its kernel too.

Dry::CLI::Launcher[registry] runs a CLI with the arguments, streams and
kernel in the order Aruba's in-process launcher passes them, so a CLI can
be tested in the same process with StringIO streams.
Registry#tree, Dry::CLI#tree and Dry::CLI::Tree.for return a live view of
the registered commands, for gems that describe a CLI rather than run it:
help screens, shell completion, documentation generators. Until now they
could only walk CommandRegistry internals.

Tree::Node#resolve shares its lookup with dispatch (CommandRegistry.lookup),
so the command it finds is the one the CLI would run. Tree::Param is a
frozen snapshot of an option or argument, including every declared key.
Exit through an injectable kernel; add Launcher
One expectation per example, no local variables, described_class for the type under test.
metadata, desc, default and aliases shared their arrays, hashes and strings with the Option declaration, so appending to metadata[:aliases] added a live switch to the CLI. Each is now a frozen copy.
tmp, args, i and numbered block parameters become child, arguments, index and named parameters. CommandRegistry.lookup also folds its two not-found branches into one; behavior is unchanged.
Proposal 2 of 4 in the dry-cli extension hooks series. 

## Summary

A public, **read-only**, **live** view of the commands, replacing the `CommandRegistry` / `LookupResult` / `Node` internals that help completion gems walk today.

```ruby
# Registry#tree   (also Dry::CLI#tree, Tree.for(command))
root = MyApp::Commands.tree            

root["db"]                             # by name or alias
root.dig("db", "migrate")
node, rest = root.resolve(%w[db migrate --force])  # same lookup as dispatch
root.walk(hidden: false) { |node| … }
node.options.first                     # Tree::Param: name, kind, type, desc, values, switches, metadata…
```

```diff
 CommandRegistry
-  #get(arguments)            # lookup inlined under the mutex
+  #get(arguments)            # synchronize { .lookup(@root, arguments) }
+  .lookup(node, arguments)   # shared with Tree::Node#resolve
+  #root
```

- Live: reads go to the registry, so commands and options added after `tree` was taken are visible (needed for dynamic completion).

- `Param#metadata` carries every declared key, so extensions read their own (i.e., `file: true`).

- `CommandRegistry`, `Option`, `Argument` stay `@api private`.

## Evidence

- **Before:** dry-cli-autocomplete: `registry.get(path).children.reject { _2.hidden }`; dry-cli-help: `node.parent.aliases.filter_map { … }`.

- **After:** `tree.walk(hidden: false)` and `node.aliases`. `spec/unit/dry/cli/tree_spec.rb`: 30 examples, including resolve-vs-dispatch parity over 10 command lines and liveness. Full suite **661 examples, 0 failures**; rubocop clean.

## Merge Risk

Additive; `CommandRegistry#get` is refactored but behaves identically (whole suite unchanged).

## Blast Radius 

Believed to be small.

## If merged, what changes in the futue:

- New public surface (`Tree`) that dry-cli would need to commit to keeping stable.
@kigster kigster closed this Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant