Skip to content

Count Amazon's time servers as time sync #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drudge merged 2 commits into from
Sep 29, 2026
Merged

Count Amazon's time servers as time sync #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3b254b
Count Amazon's time servers as time sync
drudge Sep 29, 2026
3a9e49a
Merge branch 'main' into claude/amazon-time-servers
drudge Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/insights/devices/apps_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ func TestChangesReportAppsADeviceStartedUsing(t *testing.T) {
{Name: "mesu.apple.com", FirstSeen: testNow.Add(-time.Hour)},
// A brand's public time server is time sync, not the brand's app.
{Name: "time.facebook.com", FirstSeen: testNow.Add(-time.Hour)},
{Name: "ntp-g7g.amazon.com", FirstSeen: testNow.Add(-time.Hour)},
// Remote access has a finding of its own.
{Name: "region1.v2.argotunnel.com", FirstSeen: testNow.Add(-time.Hour)},
},
Expand Down
2 changes: 1 addition & 1 deletion internal/insights/services/catalog.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ var catalog = []catalogEntry{
// Big brands run public time servers under their own domains. Listing them
// here keeps a clock sync from counting as the brand's app, as when a smart
// switch sets its clock from time.facebook.com.
{Service{"ntp", "Time sync", CategoryPlatform}, []string{"pool.ntp.org", "time.apple.com", "time.windows.com", "time.google.com", "time1.google.com", "time2.google.com", "time3.google.com", "time4.google.com", "time.cloudflare.com", "time.facebook.com", "time1.facebook.com", "time2.facebook.com", "time3.facebook.com", "time4.facebook.com", "time5.facebook.com"}},
{Service{"ntp", "Time sync", CategoryPlatform}, []string{"pool.ntp.org", "time.apple.com", "time.windows.com", "time.google.com", "time1.google.com", "time2.google.com", "time3.google.com", "time4.google.com", "time.cloudflare.com", "time.facebook.com", "time1.facebook.com", "time2.facebook.com", "time3.facebook.com", "time4.facebook.com", "time5.facebook.com", "ntp-g7g.amazon.com", "time.aws.com"}},

// Finance.
{Service{"paypal", "PayPal", CategoryFinance}, []string{"paypal.com", "paypalobjects.com", "venmo.com"}},
Expand Down
2 changes: 2 additions & 0 deletions internal/insights/services/services_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ func TestLookupPrefersTheMostSpecificOwner(t *testing.T) {
{"time.facebook.com", "ntp"},
{"time3.facebook.com", "ntp"},
{"time2.google.com", "ntp"},
{"ntp-g7g.amazon.com", "ntp"},
{"www.amazon.com", "amazon"},
{"www.facebook.com", "facebook"},
{"mail.google.com", "gmail"},
{"eu.tectonic.remarkable.com", "remarkable"},
Expand Down
Loading