Skip to content

feat(design-system): add DsFiltersBar search field [AR-97344] - #748

Open
iromanchuk-dn wants to merge 4 commits into
mainfrom
claude/ar-97344-implementation-plan-6ca1a9
Open

iromanchuk-dn wants to merge 4 commits into
mainfrom
claude/ar-97344-implementation-plan-6ca1a9

Conversation

@iromanchuk-dn

Copy link
Copy Markdown
Collaborator

Search field for DsFiltersBar (DsFiltersBar.Search), plus a chip for each search in DsFiltersBar.Conditions.

  • Enter adds the trimmed text as a search condition and clears the input. The same search is not added twice. / focuses the input from anywhere except a text field or a dialog.
  • The search is disabled while an Advanced query (a query with OR or parentheses) is the source.
  • Search chips appear after the "+" button. Clicking a chip moves its text back into the input for editing; its × removes it. Field-condition chips are left to AR-97320.
  • Search now reports onValueChange while uncontrolled. Root's useReportedState moved to its own file so both use it.

Please confirm:

  • Chips use DsTag's selected style to match Figma's colours and always-visible ×. Because the chip is clickable, this also sets aria-pressed="true".
  • DsTag medium is 30px tall versus 28px in Figma.

@netlify

netlify Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for drivenets-design-system ready!

Name Link
🔨 Latest commit 3af717a
🔍 Latest deploy log https://app.netlify.com/projects/drivenets-design-system/deploys/6abcfd07e01e620008761994
😎 Deploy Preview https://deploy-preview-748--drivenets-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment thread packages/design-system/src/components/ds-filters-bar/ds-filters-bar.module.scss Outdated

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants