feat(design-system): add submenus and tooltips to DsTable secondary row actions [AR-81152] - #747
Open
iromanchuk-dn wants to merge 5 commits into
Conversation
…able secondary row actions [AR-81152] - `secondaryRowActions` items can declare `children` (instead of `onClick`) to render a cascading submenu; `hidden`/`disabled` apply to the subtree and parents with no visible children are omitted - `tooltip` is now rendered for secondary actions, including on disabled items, and can be resolved per row - a disabled parent renders as a disabled item with a greyed chevron and never opens Co-authored-by: Claude <noreply@anthropic.com>
✅ Deploy Preview for drivenets-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
iromanchuk-dn
changed the title
iromanchuk-dn
commented
Sep 30, 2026
…-81152] Co-authored-by: Claude <noreply@anthropic.com>
…om:iromanchuk-dn/design-system into claude/ar-81152-implementation-plan-78e2e9
vpolessky-dn
approved these changes
Sep 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unblocks Workflow Catalog's move onto
DsTable'ssecondaryRowActions(AR-81152, blocking AR-72353).childreninstead ofonClick, and it renders as a submenu opening to the right. The type is a union, so an item has eitheronClickorchildren, never both; existing flat actions still type-check.hiddenanddisabledon a parent apply to the whole submenu.tooltipwas declared but never rendered for secondary actions. It now shows on hover, including on disabled items, for the permissions "visible but disabled" pattern. The tooltip wraps the item's content, not the menu item itself, so it doesn't override the item'sidand data attributes.tooltipalso accepts(row) => string | undefined. Primary actions resolve it the same way for theirtitle.Stories
Components/Table/Row Actionsgets two new stories:WithNestedSecondaryActions: the Workflow Catalog "Review PR" and "Filter by workflow" menus.WithDisabledActionReasons: the permissions case.The docs snapshot is regenerated.
Tests
There are 5 new browser tests in
ds-table-row-actions.browser.test.tsx:onClickreceives the row data and doesn't triggeronRowClick.onClickreceives the row data and doesn't triggeronRowClick.onClick.ds-table-columns"toggle column visibility" andds-table-selection"select column alongside the reorder drag handle" fail onmaintoo; they don't involve row actions.Follow-ups (not in this PR)
pointer-events: none, so theirtitlenever shows. It's the same permissions gap.