Title: Fix resolve() argument-count crash and add PHP 8 + Doctrine DBAL 4.x compatibility by marinhekman · Pull Request #34 · driftphp/reactphp-dbal

ignore Jetbrains project folder

marinhekman

committed

747ebed

Update doctrine/dbal requirement to support version 4

marinhekman

committed

6145d03

Update doctrine/dbal requirement to support version 4

marinhekman

committed

2c56542

releaseConnection() call resolve() with zero arguments, but the installed react/promise (^3.3) requires exactly one argument

marinhekman

committed

eaadaf8

Merge branch 'master' of https://github.com/BredaUniversityResearch/reactphp-dbal

marinhekman

committed

aee7492

fix for Error: Call to undefined function React\Promise\map()

marinhekman

committed

b756688

fix: replace removed React\Promise\map and align mock DBAL signatures across versions

marinhekman

committed

01b586b

Cause: Doctrine\DBAL\Exception\InvalidArgumentException::fromEmptyCriteria() was removed in DBAL 4 — the class now just extends plain \InvalidArgumentException with no static factories.

marinhekman

committed

a6e7a92

Doctrine\DBAL\Driver\Exception::getSQLState() requires an explicit : ?string return type, but Drift\DBAL\Driver\Exception::getSQLState() had none. PHP requires return types to match the interface o…

marinhekman

committed

837df8e

Cause: ExpressionBuilder::orX()/andX() were removed in DBAL 4 (deprecated since DBAL 3.3, replaced by or()/and()). tests\ConnectionTest.php (line 231) still called orX().

marinhekman

committed

d847321

Cause: Doctrine\DBAL\Exception became an interface in DBAL 4 (it was a concrete/instantiable class in DBAL 3). src\Driver\PostgreSQL\PostgreSQLDriver.php did new Exception('Connection closed') in t…

marinhekman

committed

0a2c639

Fixed (actionable): tests\ConnectionTest.php — usort() comparator returned a bool ($a1['id'] > $a2['id']), deprecated since PHP 8.1 (spaceship required). Changed to $a1['id'] <=> $a2['id'].

marinhekman

committed

caba18c

vendor issue: The React\MySQL\Commands\QueryCommand::$message/$resultFields dynamic property deprecations (PHP 8.2) come from vendor\react\mysql\src\Io\Parser.php, third-party code. so:

marinhekman

committed

cccf807

Cause: DBAL 4 renamed Doctrine\DBAL\Platforms\SqlitePlatform (DBAL 3) to Doctrine\DBAL\Platforms\SQLitePlatform — a hard rename, no BC alias.

marinhekman

committed

6e18ee2

Navigation Menu

Uh oh!

Title: Fix resolve() argument-count crash and add PHP 8 + Doctrine DBAL 4.x compatibility - #34

Title: Fix resolve() argument-count crash and add PHP 8 + Doctrine DBAL 4.x compatibility#34
marinhekman wants to merge 14 commits into
driftphp:masterfrom
BredaUniversityResearch:master

Commits on Sep 10, 2026

ignore Jetbrains project folder

Update doctrine/dbal requirement to support version 4

Update doctrine/dbal requirement to support version 4

releaseConnection() call resolve() with zero arguments, but the installed react/promise (^3.3) requires exactly one argument

Merge branch 'master' of https://github.com/BredaUniversityResearch/reactphp-dbal

fix for Error: Call to undefined function React\Promise\map()

fix: replace removed React\Promise\map and align mock DBAL signatures across versions

Cause: Doctrine\DBAL\Exception\InvalidArgumentException::fromEmptyCriteria() was removed in DBAL 4 — the class now just extends plain \InvalidArgumentException with no static factories.

Doctrine\DBAL\Driver\Exception::getSQLState() requires an explicit : ?string return type, but Drift\DBAL\Driver\Exception::getSQLState() had none. PHP requires return types to match the interface o…

Cause: ExpressionBuilder::orX()/andX() were removed in DBAL 4 (deprecated since DBAL 3.3, replaced by or()/and()). tests\ConnectionTest.php (line 231) still called orX().

Cause: Doctrine\DBAL\Exception became an interface in DBAL 4 (it was a concrete/instantiable class in DBAL 3). src\Driver\PostgreSQL\PostgreSQLDriver.php did new Exception('Connection closed') in t…

Fixed (actionable): tests\ConnectionTest.php — usort() comparator returned a bool ($a1['id'] > $a2['id']), deprecated since PHP 8.1 (spaceship required). Changed to $a1['id'] <=> $a2['id'].

vendor issue: The React\MySQL\Commands\QueryCommand::$message/$resultFields dynamic property deprecations (PHP 8.2) come from vendor\react\mysql\src\Io\Parser.php, third-party code. so:

Cause: DBAL 4 renamed Doctrine\DBAL\Platforms\SqlitePlatform (DBAL 3) to Doctrine\DBAL\Platforms\SQLitePlatform — a hard rename, no BC alias.