Skip to content

[#3246] Made the installer decide database-in-image storage and removed its code from projects that do not use it. - #3263

Merged
AlexSkrypnyk merged 3 commits into
mainfrom
feature/3246-db-image-install
Nov 3, 2026
Merged

AlexSkrypnyk merged 3 commits into
mainfrom
feature/3246-db-image-install

Conversation

@AlexSkrypnyk

@AlexSkrypnyk AlexSkrypnyk commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Closes #3246

Summary

The installer now decides whether a project uses database-in-image storage, and strips the image-only code from projects that don't. The Deploy DB image CI step, ahoy pull-db and the image reload in ahoy provision ship only with the container_registry database source. The nightly VORTEX_DB_IMAGE_BASE and VORTEX_EXPORT_DB_CONTAINER_REGISTRY_PUSH_PROCEED settings ship when either the main or the migration database uses container_registry, through a new DB_IN_IMAGE token that DatabaseFetchSource::process() resolves.

Before this, every installed project carried the whole image path and decided at runtime with [ -z "${VORTEX_DB_IMAGE}" ] checks in .github/workflows/build-test-deploy.yml, .circleci/config.yml and .ahoy.yml. A project on url, ftp, s3, acquia or lagoon got a Deploy DB image step that always printed "not used" and exited, plus a pull-db command that did nothing. Migration projects on a dump source also got VORTEX_DB_INDEX=2 ./vendor/bin/vortex-refresh-db and VORTEX_REFRESH_DB2_PROCEED, which only do anything with a migration image.

After merge, a dump-source project's CI and .ahoy.yml have no image code in them at all, and a container_registry project gets the same steps without the runtime guard. The VORTEX_DB_IMAGE guard in Deploy DB image stays in the raw template inside a VORTEX_DEV fence, because Vortex's own nightly runs the raw workflow on the url source with push turned on. The shipped vortex-* tooling scripts and the ${VORTEX_DB_IMAGE:-...} fallback in docker-compose.yml are unchanged. A project that set VORTEX_DB_IMAGE by hand on a dump source, which the installer has never offered, loses Deploy DB image on its next Vortex update.

Before / After

BEFORE - every installed project
┌───────────────────────────────────────────────┐
│ nightly env: VORTEX_DB_IMAGE_BASE, PUSH=1     │
│ Export DB:   refresh-db (+ DB_INDEX=2 if mig) │
│ Deploy DB image:                              │
│   [ -z VORTEX_DB_IMAGE ] -> exit 0            │
│ ahoy provision: [ -n VORTEX_DB_IMAGE ] reload │
│ ahoy pull-db:   [ -n VORTEX_DB_IMAGE ] pull   │
└───────────────────────────────────────────────┘
  every [ -z / -n ] check decided at runtime

AFTER - decided by the installer
             database source?
        ┌──────────┴───────────┐
        ▼                      ▼
 url/ftp/s3/acquia/     container_registry
 lagoon/none            (main DB)
 ┌──────────────────┐   ┌────────────────────────────┐
 │ Export DB:       │   │ nightly env: BASE, PUSH=1  │
 │   refresh-db     │   │ Export DB: refresh-db      │
 │ (no image code)  │   │ Deploy DB image (no guard) │
 └──────────────────┘   │ ahoy provision: reload     │
                        │ ahoy pull-db               │
                        └────────────────────────────┘

 migration DB on container_registry
   -> nightly env: BASE, PUSH=1            (DB_IN_IMAGE)
   -> Export DB: DB_INDEX=2 refresh-db
   -> .env: VORTEX_REFRESH_DB2_PROCEED

Changes

Installer

  • DatabaseFetchSource::process() removes the new DB_IN_IMAGE token unless the main database or the migration database uses container_registry.
  • MigrationFetchSourceHandlerProcessTest asserts both sides: url drops VORTEX_REFRESH_DB2_PROCEED, the indexed refresh, VORTEX_DB_IMAGE_BASE and Deploy DB image; migration-only container_registry keeps the first 3 and still drops Deploy DB image.
  • .vortex/installer/CLAUDE.md lists the database tokens.

CI (build-test-deploy.yml, config.yml)

  • Nightly image variables are fenced with DB_IN_IMAGE, and their "(if database-in-image storage is used)" qualifiers are gone.
  • Deploy DB image is fenced with DB_FETCH_SOURCE_CONTAINER_REGISTRY; its VORTEX_DB_IMAGE guard is fenced with VORTEX_DEV.
  • The indexed vortex-refresh-db call moved from the MIGRATION fence to MIGRATION_DB_FETCH_SOURCE_CONTAINER_REGISTRY.
  • vortex-test-didi.yml and vortex-test-common.yml are regenerated from the sources.

Ahoy and .env

  • ahoy provision reloads the database container unconditionally inside a DB_FETCH_SOURCE_CONTAINER_REGISTRY fence.
  • ahoy pull-db is fenced the same way and runs docker pull "${VORTEX_DB_IMAGE}" without a check.
  • VORTEX_REFRESH_DB2_PROCEED moved into the MIGRATION_DB_FETCH_SOURCE_CONTAINER_REGISTRY block.

Docs

  • Deploy DB image, ahoy pull-db, the ahoy provision reload and the migration image refresh are documented as shipping with the container_registry source.

Fixtures

  • Regenerated with ahoy update-snapshots. The baseline loses the image code, and db_fetch_source_container_registry gains it back.

Summary by CodeRabbit

  • Behavior Changes

    • When the container registry is selected as the database source, provisioning now confirms and reloads the database before continuing.
    • The database image pull command is available only with the container registry source, and pull failures are now reported.
    • Database image refresh and deployment steps now follow the selected database source and configuration, including migration database settings.
  • Documentation

    • Clarified when database images are refreshed and deployed, the related timeout behavior, and when the image pull command is available.

@AlexSkrypnyk AlexSkrypnyk added the A1 Board worker 1 label Nov 2, 2026
@github-project-automation github-project-automation Bot moved this to BACKLOG in Vortex 1.x Nov 2, 2026
@AlexSkrypnyk AlexSkrypnyk added this to the 1.43.0 milestone Nov 2, 2026
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 359e773 and ad14d22.

Files selected for processing: 1
  • .vortex/docs/content/development/migrations.mdx
Files skipped from review as they are similar to previous changes: 1
  • .vortex/docs/content/development/migrations.mdx

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.

Walkthrough

Database source selection now controls installer tokens, CI database refresh and image deployment steps, and the availability of Ahoy database commands. The documentation describes the updated source conditions.

Changes: Database source gating

Layer / File(s) Summary
Installer token selection
.vortex/installer/src/Prompts/Handlers/DatabaseFetchSource.php, .vortex/installer/tests/Functional/Prompts/Handlers/MigrationFetchSourceHandlerProcessTest.php, .vortex/installer/CLAUDE.md
DatabaseFetchSource preserves DB_IN_IMAGE for container-registry database sources. Functional tests check generated settings for URL and container-registry sources. The installer token documentation lists the database fetch-source tokens.
Ahoy database commands
.ahoy.yml, .vortex/docs/content/development/environment/ahoy.mdx, .vortex/docs/content/development/provision.mdx
provision reloads the database when the database source is container_registry. pull-db is available only for that source and runs docker pull without suppressing failures.
CI refresh and deployment
.circleci/*, .github/workflows/*, .env, .vortex/docs/content/continuous-integration/*, .vortex/docs/content/development/migrations.mdx
CI migration refreshes use MIGRATION_DB_FETCH_SOURCE_CONTAINER_REGISTRY. Database-image deployment is gated by DB_FETCH_SOURCE_CONTAINER_REGISTRY, with the VORTEX_DB_IMAGE check limited to VORTEX_DEV in the specified jobs. Scheduled image settings are gated by DB_IN_IMAGE. Documentation describes the source-specific refresh and timeout conditions.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: Minimal · up to ad14d

The documented migration-image refresh condition matches the CI behavior. No actionable merge risk remains from the reviewed change.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately summarizes the main change: the installer controls database-in-image storage and removes related code when projects do not use it.
Linked Issues check Passed Issue #3246 requires an installation-time decision for database-in-image storage and removal of unused image code. DatabaseFetchSource::process() keeps DB_IN_IMAGE when the main or migration sourc…
Out of Scope Changes check Passed The changes stay within issue #3246. Documentation, installer token documentation, functional tests, regenerated workflow files, and fixtures support or verify the installation-time database-image dec…
Full details: Linked Issues check

Explanation

Issue #3246 requires an installation-time decision for database-in-image storage and removal of unused image code. DatabaseFetchSource::process() keeps DB_IN_IMAGE when the main or migration source is container_registry and removes it otherwise. The workflow, Ahoy, .env, and migration refresh sections use source-specific tokens. The functional tests verify removal for URL sources and retention for migration-only container-registry sources.

Full details: Out of Scope Changes check

Explanation

The changes stay within issue #3246. Documentation, installer token documentation, functional tests, regenerated workflow files, and fixtures support or verify the installation-time database-image decision. The retained VORTEX_DEV guard and unchanged tooling and Compose fallback preserve required raw-template behavior.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comments: 1
.github/workflows/build-test-deploy.yml-326-326: 1

326-326: Major · Data Integrity & Integration · Heavy lift

Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.

Preserve file-to-image configurations on update.

An existing project can fetch a dump from url and store it in VORTEX_DB_IMAGE. These gates remove its image deployment step on update. The nightly settings are also removed, so the registry image stops receiving fresh data. The migration refresh gate has the same effect for VORTEX_DB2_IMAGE. The refresh script supports both configurations. (github.com)

Select image storage separately from the fetch source, and retain the relevant refresh and deployment code when image storage is enabled. Apply the same change to CircleCI.

Also applies to: 332-332


Review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 43d4d24 and 359e773.

Files ignored due to path filters: 109
  • .vortex/installer/tests/Fixtures/handler_process/_baseline/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/_baseline/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/ciprovider_circleci/.circleci/config.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/code_coverage_provider_codecov/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/code_coverage_provider_codecov_circleci/.circleci/config.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/db_fetch_source_acquia/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/db_fetch_source_container_registry/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/db_fetch_source_container_registry/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/deploy_types_all_circleci/.circleci/config.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/deploy_types_none_circleci/.circleci/config.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/deploy_types_none_gha/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/deps_updates_provider_ci_circleci/.circleci/config.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/hosting_acquia/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_disabled_circleci/.circleci/config.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_enabled/.env is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_enabled/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_enabled_circleci/.circleci/config.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_enabled_circleci/.env is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_enabled_lagoon/.env is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_enabled_lagoon/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_acquia/.env is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_acquia/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_container_registry/.env is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_container_registry/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_ftp/.env is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_ftp/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_lagoon/.env is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_lagoon/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_s3/.env is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_s3/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_url/.env is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_url/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/modules_no_dev_modules_storybook/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/modules_no_dev_modules_storybook/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/modules_no_devel_sdc_devel/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/modules_no_devel_sdc_devel/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/modules_no_devel_sdc_devel_generated_content/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/modules_no_devel_sdc_devel_generated_content/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/modules_no_devel_sdc_devel_generated_content_testmode/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/modules_no_devel_sdc_devel_generated_content_testmode/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/modules_no_devel_sdc_devel_generated_content_testmode_reroute_email/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/modules_no_devel_sdc_devel_generated_content_testmode_reroute_email/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/modules_no_sdc_devel/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/modules_no_sdc_devel/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/modules_none/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/modules_none/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/provision_profile/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/storybook_enabled/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/theme_claro/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/theme_claro/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/theme_olivero/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/theme_olivero/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/theme_stark/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/theme_stark/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/timezone_circleci/.circleci/config.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_lint/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_lint_circleci/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_lint_circleci/.circleci/config.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/.circleci/config.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_circleci/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_circleci/.circleci/config.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme_circleci/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme_circleci/.circleci/config.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_behat/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_behat/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/.circleci/config.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_dclint_circleci/.circleci/config.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_dclint_migration/.env is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_dclint_migration/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_docker_linters_circleci/.circleci/config.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_circleci/.circleci/config.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_no_stylelint/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_no_theme/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_no_theme/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_hadolint_circleci/.circleci/config.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_jest/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_jest/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_jest_circleci/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_jest_circleci/.circleci/config.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_phpcs/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_phpcs_circleci/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_phpcs_circleci/.circleci/config.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_phpstan/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_phpstan_circleci/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_phpstan_circleci/.circleci/config.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit_circleci/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit_circleci/.circleci/config.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_rector/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_rector_circleci/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_rector_circleci/.circleci/config.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_stylelint_circleci/.circleci/config.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_stylelint_no_theme/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_stylelint_no_theme/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_twig/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_twig_circleci/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_twig_circleci/.circleci/config.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_none/.ahoy.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_none/.github/workflows/build-test-deploy.yml is excluded by !.vortex/installer/tests/Fixtures/**
Files selected for processing: 14
  • .ahoy.yml
  • .circleci/config.yml
  • .circleci/vortex-test-common.yml
  • .env
  • .github/workflows/build-test-deploy.yml
  • .github/workflows/vortex-test-didi.yml
  • .vortex/docs/content/continuous-integration/circleci.mdx
  • .vortex/docs/content/continuous-integration/github-actions.mdx
  • .vortex/docs/content/development/environment/ahoy.mdx
  • .vortex/docs/content/development/migrations.mdx
  • .vortex/docs/content/development/provision.mdx
  • .vortex/installer/CLAUDE.md
  • .vortex/installer/src/Prompts/Handlers/DatabaseFetchSource.php
  • .vortex/installer/tests/Functional/Prompts/Handlers/MigrationFetchSourceHandlerProcessTest.php

Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.

@github-actions

This comment has been minimized.

@AlexSkrypnyk

This comment has been minimized.

1 similar comment
@AlexSkrypnyk

This comment has been minimized.

@AlexSkrypnyk

This comment has been minimized.

@github-actions

This comment has been minimized.

@AlexSkrypnyk

This comment has been minimized.

1 similar comment
@AlexSkrypnyk

This comment has been minimized.

@github-actions

This comment has been minimized.

@AlexSkrypnyk

Copy link
Copy Markdown
Member Author

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (233/233)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@codecov

codecov Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.28%. Comparing base (43d4d24) to head (ad14d22).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3263      +/-   ##
==========================================
- Coverage   92.46%   92.28%   -0.19%     
==========================================
  Files         116      108       -8     
  Lines        5219     5056     -163     
  Branches       49        3      -46     
==========================================
- Hits         4826     4666     -160     
+ Misses        393      390       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

📖 Documentation preview for this pull request has been deployed to Netlify:

https://6ae86f26630375cbd880a2b2--vortex-docs.netlify.app

This preview is rebuilt on every commit and is not the production documentation site.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (233/233)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk AlexSkrypnyk added the Needs review Pull request needs a review from assigned developers label Nov 2, 2026
@AlexSkrypnyk
AlexSkrypnyk merged commit cc095e0 into main Nov 3, 2026
48 checks passed
@AlexSkrypnyk
AlexSkrypnyk deleted the feature/3246-db-image-install branch November 3, 2026 03:46
@github-project-automation github-project-automation Bot moved this from BACKLOG to Release queue in Vortex 1.x Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A1 Board worker 1 Needs review Pull request needs a review from assigned developers

Projects

Status: Release queue

Development

Successfully merging this pull request may close these issues.

Make DB-in-image install-based decision and remove any code when it is not used

1 participant