Repository navigation
Updated 'drevops/behat-steps' to the stable 4.0.0 and moved the sitemap Behat check onto the REST session. - #3262
Conversation
…ap Behat request through the REST session.
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Behat dependency and sitemap request composer.json, tests/behat/features/xmlsitemap.feature |
The drevops/behat-steps constraint changed to ^4.0.0. The sitemap scenario sends GET /sitemap.xml and checks that the REST response status is 200. |
Estimated code review effort: 1 (Trivial) | ~4 minutes
Merge Risk: 
Minimal · up to 003c5
-
The dependency and sitemap test updates align with the reported Behat 4.0.0 usage and are ready to merge.
Pre-merge checks: 
4
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
|
Code coverage (threshold: 90%) Per-class coverage |
|
📖 Documentation preview for this pull request has been deployed to Netlify: https://6ae8470b168372d690b22ffa--vortex-docs.netlify.app This preview is rebuilt on every commit and is not the production documentation site. |
Summary
composer.jsonnow requiresdrevops/behat-stepsat^4.0.0instead of^4.0@rc, so Composer installs the stable 4.0.0 release (tagged 2026-11-02) and stops admitting release candidates.4.0.0 moved the REST, JSON and XML steps onto a dedicated
restMink session. The XML steps now read only the last REST response and fail withNo REST request has been sent in this scenario.when the page was loaded by the browser, which is exactly whattests/behat/features/xmlsitemap.featuredid withI go to "/sitemap.xml". That scenario now fetches the sitemap withI send a REST "GET" request to "/sitemap.xml"and checksthe REST response status code should be 200, following the library'sMIGRATION.md("REST, JSON and XML responses").behat.php,FeatureContextand the rest of the features stay as they are: between rc4 and 4.0.0 the library only added step definitions and moved the REST session, and the other XML/JSON scenarios inbehat.featureload their responses from fixture files, which still works. Verified locally on 4.0.0 with a fresh resolve: dry-run 29 scenarios / 201 steps with none undefined, and the full suite 29 / 201 passed (including@clamav). The installer_baselinefixture picks up the feature file change; all other scenarios are unchanged.Before / After
Changes
Dependencies
composer.json:drevops/behat-steps^4.0@rc->^4.0.0, matching thebehat/behat^4.0.0constraint style.Behat
tests/behat/features/xmlsitemap.feature: request the sitemap through the REST session and assert the REST response status code, so the XML assertions read the same response.Installer fixtures
.vortex/installer/tests/Fixtures/handler_process/_baseline/tests/behat/features/xmlsitemap.feature: regenerated for the feature file change.Summary by CodeRabbit
/sitemap.xmldirectly and confirms the response status is 200. This verifies the sitemap endpoint’s availability through the REST response rather than browser navigation.