Skip to content

Updated 'drevops/behat-steps' to the stable 4.0.0 and moved the sitemap Behat check onto the REST session. - #3262

Merged
AlexSkrypnyk merged 2 commits into
mainfrom
feature/behat-steps-4
Nov 2, 2026
Merged

AlexSkrypnyk merged 2 commits into
mainfrom
feature/behat-steps-4

Conversation

@AlexSkrypnyk

@AlexSkrypnyk AlexSkrypnyk commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Summary

composer.json now requires drevops/behat-steps at ^4.0.0 instead of ^4.0@rc, so Composer installs the stable 4.0.0 release (tagged 2026-11-02) and stops admitting release candidates.

4.0.0 moved the REST, JSON and XML steps onto a dedicated rest Mink session. The XML steps now read only the last REST response and fail with No REST request has been sent in this scenario. when the page was loaded by the browser, which is exactly what tests/behat/features/xmlsitemap.feature did with I go to "/sitemap.xml". That scenario now fetches the sitemap with I send a REST "GET" request to "/sitemap.xml" and checks the REST response status code should be 200, following the library's MIGRATION.md ("REST, JSON and XML responses").

behat.php, FeatureContext and the rest of the features stay as they are: between rc4 and 4.0.0 the library only added step definitions and moved the REST session, and the other XML/JSON scenarios in behat.feature load their responses from fixture files, which still works. Verified locally on 4.0.0 with a fresh resolve: dry-run 29 scenarios / 201 steps with none undefined, and the full suite 29 / 201 passed (including @clamav). The installer _baseline fixture picks up the feature file change; all other scenarios are unchanged.

Before / After

BEFORE (behat-steps ^4.0@rc -> 4.0.0)

  xmlsitemap.feature
    I go to "/sitemap.xml" ──► browser session (page)
    response status code == 200 ──► browser session        OK
    XML steps ──────────────────► rest session (empty)     FAIL: No REST request
                                                           has been sent

AFTER (behat-steps ^4.0.0)

  xmlsitemap.feature
    I send a REST "GET" request to "/sitemap.xml" ──► rest session
    REST response status code == 200 ───────────────► rest session  OK
    XML steps ──────────────────────────────────────► rest session  OK

Changes

Dependencies

  • composer.json: drevops/behat-steps ^4.0@rc -> ^4.0.0, matching the behat/behat ^4.0.0 constraint style.

Behat

  • tests/behat/features/xmlsitemap.feature: request the sitemap through the REST session and assert the REST response status code, so the XML assertions read the same response.

Installer fixtures

  • .vortex/installer/tests/Fixtures/handler_process/_baseline/tests/behat/features/xmlsitemap.feature: regenerated for the feature file change.

Summary by CodeRabbit

  • Tests
    • Sitemap validation now requests /sitemap.xml directly and confirms the response status is 200. This verifies the sitemap endpoint’s availability through the REST response rather than browser navigation.

@AlexSkrypnyk AlexSkrypnyk added the A2 Working clone index A2 label Nov 2, 2026
@github-project-automation github-project-automation Bot moved this to BACKLOG in Vortex 1.x Nov 2, 2026
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 041b48d and 003c53a.

Files ignored due to path filters: 1
  • .vortex/installer/tests/Fixtures/handler_process/_baseline/tests/behat/features/xmlsitemap.feature is excluded by !.vortex/installer/tests/Fixtures/**
Files selected for processing: 2
  • composer.json
  • tests/behat/features/xmlsitemap.feature

Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.

Walkthrough

The Behat dependency constraint changed from ^4.0@rc to ^4.0.0. The sitemap scenario now sends a REST GET request to /sitemap.xml and asserts that the REST response status is 200.

Changes: Sitemap response check

Layer / File(s) Summary
Behat dependency and sitemap request
composer.json, tests/behat/features/xmlsitemap.feature
The drevops/behat-steps constraint changed to ^4.0.0. The sitemap scenario sends GET /sitemap.xml and checks that the REST response status is 200.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Merge Risk: Minimal · up to 003c5

The dependency and sitemap test updates align with the reported Behat 4.0.0 usage and are ready to merge.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately summarizes both main changes: updating drevops/behat-steps to stable 4.0.0 and moving the sitemap Behat check to the REST session.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@github-actions

This comment has been minimized.

@AlexSkrypnyk

This comment has been minimized.

@github-actions

This comment has been minimized.

@AlexSkrypnyk

Copy link
Copy Markdown
Member Author

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (233/233)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (233/233)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

📖 Documentation preview for this pull request has been deployed to Netlify:

https://6ae8470b168372d690b22ffa--vortex-docs.netlify.app

This preview is rebuilt on every commit and is not the production documentation site.

@AlexSkrypnyk
AlexSkrypnyk merged commit 7ec1e69 into main Nov 2, 2026
44 of 45 checks passed
@AlexSkrypnyk
AlexSkrypnyk deleted the feature/behat-steps-4 branch November 2, 2026 08:24
@github-project-automation github-project-automation Bot moved this from BACKLOG to Release queue in Vortex 1.x Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A2 Working clone index A2

Projects

Status: Release queue

Development

Successfully merging this pull request may close these issues.

1 participant