Repository navigation
Upgraded 'drevops/phptui' to 0.3 and '.vortex/docs' to ESLint 10. - #3238
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
AlexSkrypnyk
enabled auto-merge (rebase)
October 26, 2026 06:43
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #3238 +/- ##
=======================================
Coverage 88.33% 88.33%
=======================================
Files 111 111
Lines 6165 6165
Branches 3 3
=======================================
Hits 5446 5446
Misses 719 719 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…lements with its bundled React 16.
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Code coverage (threshold: 90%) Per-class coverage |
|
📖 Documentation preview for this pull request has been deployed to Netlify: https://6ae00d04c27986ea2c41ea80--vortex-docs.netlify.app This preview is rebuilt on every commit and is not the production documentation site. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up the major upgrades available on
2.xthat fit the current toolchain. The in-range lock refresh for October already landed with the forward-port, so this PR covers what sits outside the existing constraints..vortex/tooling/is out of scope.What's in it
drevops/phptui0.2 → 0.3 (.vortex/cli)phptui 0.3 flipped every form builder method to label first, with the id optional and derived from the label when left out.
TuiAdapter::field()and the 12 panels inVortexForm::create()now pass(label, id). Every id is still declared explicitly, so answer keys,Conditiontargets and theVORTEX_CLI_INSTALL_PROMPT_*environment variables are unchanged. Letting phptui derive them would have renamedgeneraltogeneral_information.Nothing on screen changes, so the
cli-installvideo and the fixtures don't need regenerating.ESLint 9 → 10 (
.vortex/docs)eslint-plugin-react7.37.5 is the latest release, and it doesn't support ESLint 10 yet. Itsversion: 'detect'path callscontext.getFilename(), which ESLint 10 removed, so the config now pinssettings.react.versionto18.3. Every other rule in the plugin runs fine. It needs bumping with React until the plugin catches up, and yarn prints a peer-dependency warning in the meantime.no-useless-assignmentto the recommended set. It flagged a deadlet ok = falseinsrc/pages/index.js: both thetryand thecatchoverwrite it.Left out on purpose
React 19. Docusaurus 3.10 and the Jest suite are fine on it, but it breaks the docs video pipeline.
svg-term(unmaintained since 2022) bundles its own React 16, but its styling dependency@stiligita/reactis hoisted and resolves the top-levelreact. On React 19 that feeds React 19 elements into React 16's server renderer, andsvg-term-render.jsfails withUnknown element-like object type: Symbol(react.transitional.element). Yarn 1 can't scope that resolution per package, so moving to React 19 means replacing the SVG renderer first. The second commit tried React 19 and the third reverts it.Babel 8 and cspell 10. Both need Node
>=22.18. Every workflow that pins Node uses22.17.1, and some of those test the shipped template, not just.vortex/. That makes the Node bump its own change.svg-termrenders with React 16react^22.18.0 || >=24.11.0@babel/core@babel/core>=22.18.0Checked locally
.vortex/cli:composer lintis clean, and all 1742 tests pass..vortex/docs:lint,spellcheckandlint-proseare clean, all 230 Jest tests pass,docusaurus buildcompiles, andsvg-term-render.jsrenderscli-install.json.Summary by CodeRabbit