Repository navigation
DX-128210: Backport apache/arrow#55278 and #55282 (Gandiva decimal stack, arena release) to dremio_27.0_23_19 - #150
Merged
lriggs merged 2 commits intoNov 3, 2026
Conversation
…with JIT optimization off (apache#55278)
…ny function with context (apache#55282)
victor6567758
requested review from
g-zemlianyi,
lriggs,
myk and
tristan-sturgess
November 2, 2026 18:09
Collaborator
|
It would probably be good to build jars and run a Dremio pr with the arrow jar change for basic tests. Not strictly necessary but it will provide additional testing. I usually do that when making any substantial changes. |
Author
@lriggs tested this build with |
victor6567758
marked this pull request as ready for review
November 3, 2026 15:33
g-zemlianyi
approved these changes
Nov 3, 2026
lriggs
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of two upstream Gandiva fixes to
dremio_27.0_26_20(Arrow 26.0.0), one commit each.1. apache/arrow#55278 — apacheGH-55277, decimal return slots
Files:
cpp/src/gandiva/decimal_ir.cc,decimal_ir.h,tests/decimal_test.cc.2. apache/arrow#55282 — apacheGH-55281, per-row arena release
Files:
cpp/src/gandiva/execution_context.h,simple_arena.h,llvm_generator.cc,tests/projector_test.cc,tests/test_util.cc,tests/test_util.h.Testing
Built locally (gcc 15, Debug,
ARROW_GANDIVA=ON) and ran:gandiva-projector-test --gtest_filter=TestDecimal.CastLargeBatch— passgandiva-projector-test --gtest_filter=TestProjector.TestLevenshteinArenaGrowth:TestProjector.TestNestedStringFunctionArenaGrowth:TestProjector.TestExtendedCFunctionArenaGrowth— passgandiva-projector-test(covers both PRs' test files) — passgandiva-precompiled-test— 131/132 pass;TestTime.TestCastTimestampWithTZfails, pre-existing on the base branch and unrelated (neither PR touchesprecompiled/)Dremiobranch and confirm the issue is fixedDX-128210