Fix correlated video-action inference noise - #89
Open
zjn20030811 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Joint inference currently creates a new generator with the same seed for each modality. With the default Wan2.2 shapes, all 1,536 action-noise values are identical to the prefix of the video-noise stream (1,536/1,536). Training uses separate sequential randn_like draws, so inference starts from a different joint noise distribution.
Using one generator for both draws restores non-overlapping samples while retaining deterministic replay. In the focused default-shape check, prefix identity drops from 1,536/1,536 to 1/1,536; rerunning with the same seed reproduces both tensors exactly.
Testing