Skip to content

Fix flaky Firefox E2E in 03-system-config RBAC test - #1413

Merged
Tim020 merged 2 commits into
devfrom
fix/e2e-rbac-toast-flake
Sep 22, 2026
Merged

Tim020 merged 2 commits into
devfrom
fix/e2e-rbac-toast-flake

Conversation

@Tim020

@Tim020 Tim020 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes the first-attempt Firefox failure of 03-system-config.spec.ts › "can configure RBAC permissions for testuser" (root cause analysed in #1412).

  • The guard page.locator('.v-toast').waitFor({state:'detached'}).catch(() => {}) was a no-op: .v-toast matches two permanent containers (strict-mode violation, swallowed by .catch) and they never detach.
  • The click on .btn-close then raced the toast; Playwright's mouse move onto the toast paused its auto-dismiss (pauseOnHover), so every retry was intercepted until the 30s timeout.
  • Now waits for expect(page.locator('.v-toast__item')).toHaveCount(0) and no longer swallows errors.

Testing

  • Prettier + ESLint pass.
  • Per the issue author's analysis, this exact change passed first attempt in 4/4 full Firefox runs (vs 3/5 failing before).
  • My own full-suite run was not completed: port 8888 was held by another E2E server (concurrent run/orphan), which broke setup. Please rely on CI Firefox result.

Fixes #1412 (items 1-3). Follow-ups split out: the 13-live-show flake and CI flake visibility (item 4) are tracked in separate issues.
🤖 Generated with Claude Code

The guard waited on .v-toast, which is two permanent containers, so it hit a
strict-mode violation that .catch() swallowed. The click then raced the toast
and Playwright's mouse move paused its auto-dismiss (pauseOnHover), deadlocking
until the test timeout. Wait on .v-toast__item (removed on dismiss) instead and
stop swallowing errors.

Refs #1412

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@Tim020 Tim020 added the claude Issues created by Claude label Sep 21, 2026
@github-actions github-actions Bot added small-diff Small pull request client-v3 labels Sep 21, 2026
@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Client V3 Test Results

209 tests   209 ✅  0s ⏱️
 14 suites    0 💤
  1 files      0 ❌

Results for commit 102565c.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Client Test Results

95 tests   95 ✅  0s ⏱️
 6 suites   0 💤
 1 files     0 ❌

Results for commit 102565c.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Python Test Results

  1 files    1 suites   47s ⏱️
934 tests 934 ✅ 0 💤 0 ❌
939 runs  939 ✅ 0 💤 0 ❌

Results for commit 102565c.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Playwright E2E Results (firefox)

221 tests   221 ✅  2m 13s ⏱️
 14 suites    0 💤
  1 files      0 ❌

Results for commit 102565c.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Playwright E2E Results (chromium)

221 tests   221 ✅  2m 16s ⏱️
 14 suites    0 💤
  1 files      0 ❌

Results for commit 102565c.

♻️ This comment has been updated with latest results.

@sonarqubecloud

Copy link
Copy Markdown

@Tim020
Tim020 marked this pull request as ready for review September 22, 2026 22:17
@Tim020
Tim020 merged commit 2d57f73 into dev Sep 22, 2026
29 checks passed
@Tim020
Tim020 deleted the fix/e2e-rbac-toast-flake branch September 22, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claude Issues created by Claude client-v3 small-diff Small pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant