fix(attack-surface-management): stop downgrading cryptography and dnspython - #158
Merged
Merged
Conversation
…python The capability pinned pyOpenSSL~=25.3.0, which requires cryptography<47, and dnspython<2.8. The runtime installs capability pins beside the SDK without constraints, so binding this capability downgraded the SDK's cryptography 50.0.1 to 46.0.7 and dnspython 2.8.0 to 2.7.0. pyOpenSSL 25.3.0 and cryptography 46.0.7 both carry known advisories. bbot 3.0.2 needs only dnspython>=2.7.0,<2.9.0 and does not pin pyOpenSSL. Allow pyOpenSSL 26.x and dnspython 2.8.x. Bump to 2.0.2. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dnspython>=2.7.0,<2.8.0→dnspython>=2.7.0,<2.9.0, matching bbot 3.0.2's own requirement.pyOpenSSL~=25.3.0→pyOpenSSL>=25.3.0,<27. pyOpenSSL 26.4.0 allows cryptography 49–50.capability.yamlandpyproject.toml.Why
The runtime installs a capability's
dependencies.pythonbeside the SDK without constraints. With the old pins, binding this capability downgraded the SDK's locked cryptography 50.0.1 to 46.0.7, and dnspython 2.8.0 to 2.7.0. osv-scanner reports pyOpenSSL 25.3.0 (2 advisories, max 9.8) and cryptography 46.0.7 (4 advisories, max 8.7).Verification
Python 3.13, linux/amd64: the SDK installed from
packages/sdk/uv.lockat dreadnode-tiger7a8d3bf25, then this capability's pins installed unconstrained, the way the runtime install step does it.Not in this PR
Both of these are the same on
mainand on this branch:badsecrets~=0.13.47brings in django 4.2.30 (7 advisories, max 6.9). badsecrets 1.2.1 requires django>=5.2.15, but that is a major-version change and needs the capability owner to verify.uv pip checkreportsdreadnode requires xmltodict>=1.0.2, but 0.14.2 is installed. Something in the capability's dependency tree holds xmltodict below the SDK's minimum.🤖 Generated with Claude Code