Repository navigation
Keep caller-owned binary streams open after reading ASCII PLY - #92
Open
xixihaha-ha wants to merge 1 commit into
Open
xixihaha-ha wants to merge 1 commit into
xixihaha-ha wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading ASCII PLY from a caller-supplied binary stream creates a TextIOWrapper that closes the underlying stream when destroyed. Consequently
BytesIO.getvalue()or reusing the file afterPlyData.read()raises ValueError. This also occurs after a parsing error, whereas text streams and binary PLY streams remain open.Detach the internally created text wrapper in finally, leaving externally owned streams open while retaining the existing closure of files opened from paths. Add success and parse-error regression cases.
Validation: both new cases fail on unchanged code because the stream is closed. After the fix the complete test directory passes (123 passed), on Python 3.11 with NumPy 2.
AI assistance was used to investigate, implement and test this change.
📚 Documentation preview 📚: https://python-plyfile--92.org.readthedocs.build/en/92/