Repository navigation
docs: Go PGO works now — remove the note added when it did not (#171) - #181
Merged
Merged
Conversation
#177 added a note saying `go build -pgo=` does not accept these profiles, which was true when written. #180 populated Function.start_line and verified the Go compiler matches on it and acts: hot-callsite-thres-from-CDF=3.90987408880053 hot-node enabled increased budget=2000 for func=main.main.func1 So the note is now false and comes out, replaced by the two commands that do the thing. The inlined-frame limitation is stated rather than left for a reader to discover from a thinner profile: those frames carry no start line, Go keys its hot nodes on out-of-line functions, and it accepts and applies the profile regardless. Claude-Session: https://claude.ai/code/session_01P5889hA6CrX8ysnQkvv6im
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #180.
#177 added a note saying
go build -pgo=does not accept these profiles. That was true when written. #180 populatedFunction.start_lineand verified the Go compiler matches on it and acts on the result:So the note is now false. It comes out, replaced by the two commands that actually do the thing:
The inlined-frame limitation is stated rather than left for a reader to discover from a thinner profile: those frames carry no start line, Go keys its hot nodes on out-of-line functions, and it accepts and applies the profile regardless.
https://claude.ai/code/session_01P5889hA6CrX8ysnQkvv6im