Fix OverflowError in offsets_for_times() when timestamp is non-finite float#3119
Open
koteshyelamati wants to merge 1 commit into
Open
Fix OverflowError in offsets_for_times() when timestamp is non-finite float#3119koteshyelamati wants to merge 1 commit into
koteshyelamati wants to merge 1 commit into
Conversation
…nity Add error handling for invalid timestamps in Kafka consumer.
Owner
|
Why did or do you expect a ValueError in this case? The docstring only claims to raise ValueError for negative timestamps. I'm not sure how changing OverflowError to ValueError improves this api contract? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
offsets_for_times()converts each timestamp value withint(ts). Iftsisfloat('inf')orfloat('nan'), this raises anOverflowError(orValueErrorfor nan) instead of the expectedValueErrorwith a clear message.Reproducer:
Fix
Wrap
int(ts)in a try/except that catchesValueError,TypeError, andOverflowError, and re-raises asValueErrorwith a descriptive message — consistent with the existing negative-timestamp check.