Ignores taxonomy vocabulary configuration during configuration imports - #822
Merged
Merged
Conversation
Ignores taxonomy vocabulary configuration during configuration imports
vincent-gao
changed the title
There was a problem hiding this comment.
🟡 Changes recommended
A subsequent configuration import can overwrite the active-only ignore rule, disabling it for future imports.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds taxonomy vocabulary configuration to Config Ignore for fresh and existing installations.
Changes:
- Adds a reusable configuration-ignore operation.
- Runs it during installation and update hook
10048.
File summaries
| File | Description |
|---|---|
tide_core.install |
Invokes the ignore operation during install and update. |
src/TideCoreOperation.php |
Adds the taxonomy vocabulary ignore rule. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+352
to
+359
| $config = \Drupal::configFactory()->getEditable('config_ignore.settings'); | ||
| $ignored_config_entities = (array) $config->get('ignored_config_entities'); | ||
|
|
||
| if (!in_array('taxonomy.vocabulary.*', $ignored_config_entities, TRUE)) { | ||
| $ignored_config_entities[] = 'taxonomy.vocabulary.*'; | ||
| $config | ||
| ->set('ignored_config_entities', $ignored_config_entities) | ||
| ->save(); |
Contributor
There was a problem hiding this comment.
Well played Copilot!
Use hook_config_ignore_settings_alter() to ensure importing config_ignore.settings cannot remove the taxonomy.vocabulary.* ignore rule. Remove the configuration helper and its install and update hooks.
vincent-gao
force-pushed
the
fix/ignore-taxonomy-vocabulary-config
branch
from
September 7, 2026 22:50
f73345d to
3ce5c6b
Compare
anthony-malkoun
approved these changes
Sep 16, 2026
anthony-malkoun
left a comment
anthony-malkoun
left a comment
Contributor
There was a problem hiding this comment.
Copilot made a good call!
Contributor
Author
🤖 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.