Remove commented ActiveIssue from SslKeyLogFile test - #132703
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a stale commented-out [ActiveIssue] attribute from the SslKeyLogFile_IsCreatedAndFilled test in System.Net.Security functional tests. The change is a non-functional cleanup that reduces noise without affecting test execution.
Changes:
- Remove a commented
[ActiveIssue]annotation from the SSLKEYLOGFILE test.
MihaZupan
approved these changes
Aug 24, 2026
rzikm
enabled auto-merge (squash)
August 24, 2026 14:56
wfurt
approved these changes
Aug 24, 2026
Member
Author
|
/ba-g test failures are unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since OpenSSL seems to keep the SSLKEYLOGFILE support and there is no app-level API to prevent it to enforce our policy, there is nothing for us to do other than keep the relevant test cases disabled.
Closes #116473.