Skip to content

Extend Zstandard SmallestSize test fallback to Apple mobile platforms #132701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −4
Open

Extend Zstandard SmallestSize test fallback to Apple mobile platforms #132701

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97e25ac
Initial plan
Copilot Aug 24, 2026
82f019d
Extend Zstandard SmallestSize fallback to Apple mobile platforms
Copilot Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/libraries/System.IO.Compression/tests/Zstandard/CompressionStreamUnitTests.Zstandard.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,23 +17,23 @@ public class ZstandardStreamUnitTests : CompressionStreamUnitTestBase
public override Stream CreateStream(Stream stream, CompressionMode mode, bool leaveOpen) => new ZstandardStream(stream, mode, leaveOpen);
public override Stream CreateStream(Stream stream, CompressionLevel level)
{
if (PlatformDetection.Is32BitProcess && level == CompressionLevel.SmallestSize)
if ((PlatformDetection.Is32BitProcess || PlatformDetection.IsAppleMobile) && level == CompressionLevel.SmallestSize)
{
// Zstandard smallest size requires too much working memory
// (800+ MB) and causes intermittent allocation errors on 32-bit
// processes in CI.
// processes and on memory-constrained Apple mobile devices (iOS/tvOS/MacCatalyst) in CI.
level = CompressionLevel.Optimal;
}

return new ZstandardStream(stream, level);
}
public override Stream CreateStream(Stream stream, CompressionLevel level, bool leaveOpen)
{
if (PlatformDetection.Is32BitProcess && level == CompressionLevel.SmallestSize)
if ((PlatformDetection.Is32BitProcess || PlatformDetection.IsAppleMobile) && level == CompressionLevel.SmallestSize)
{
// Zstandard smallest size requires too much working memory
// (800+ MB) and causes intermittent allocation errors on 32-bit
// processes in CI.
// processes and on memory-constrained Apple mobile devices (iOS/tvOS/MacCatalyst) in CI.
level = CompressionLevel.Optimal;
}

Expand Down
Loading