[release/10.0] Fix concurrent Reflection.Emit TypeLoadException (#129230) - #132673
Open
github-actions[bot] wants to merge 1 commit into
Open
[release/10.0] Fix concurrent Reflection.Emit TypeLoadException (#129230)#132673github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
PR #125536 added an AddPropertyToLookUpTable call inside CMiniMdRW::AddPropertyToPropertyMap (and AddEventToLookUpTable inside AddEventToEventMap) so that the ENC/hot-reload path, which reaches those functions via metamodelenc.cpp rather than RegMeta::DefineProperty, would also maintain the property/event parent lookup table (fixing #125534). However the emit path already appended to the lookup table: DefineProperty and _DefineEvent call AddPropertyToPropertyMap/AddEventToEventMap and then also call Add*ToLookUpTable themselves, gated on HasIndirectTable. The S_FALSE branch in AddPropertyToPropertyMap fires under exactly the same condition (an indirect PropertyPtr/EventPtr table exists), so after #125536 the emit path appended the same <member, typedef> entry twice. Add*ToLookUpTable only appends once the lazily-built lookup map is non-NULL (the map is built on demand by a reader in FindParentOf*Helper). When a concurrent reader has built the map, the duplicate append desyncs the map's Count from the member RID, so a subsequently emitted member is recorded against the wrong parent typedef, surfacing as a TypeLoadException. This is why the regression only reproduces under concurrent emit + reflection. Remove the now-redundant emit-side appends so the lookup table is maintained in exactly one place (AddPropertyToPropertyMap/AddEventToEventMap), which serves both the emit and ENC/hot-reload callers and preserves the #125534 fix. Fixes #129230 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #130696 to release/10.0
/cc @steveisok
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.release/X.0(no-stagingsuffix).Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.