Annotate MemoryCache trimming requirements - #132662
Open
iamhaseebn wants to merge 1 commit into
Open
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MemoryCachereads its optional configuration throughConfigurationManager, which is not compatible with trimming. This can currently build without warnings and then fail at runtime in a NativeAOT application.Annotate both public constructors and the
MemoryCache.Defaultaccessor withRequiresUnreferencedCodeso unsupported usage produces IL2026 during build. The three-argument constructor notes that the warning can be suppressed whenignoreConfigSectionistrue. The runtime behavior remains unchanged.The annotations are mirrored in the reference assembly. Existing tests suppress the warning because their linker descriptor preserves the configuration constructor required by those scenarios.
Validated with:
dotnet build ./src/System.Runtime.Caching.csproj --no-restoredotnet build /t:test ./tests/System.Runtime.Caching.Tests.csproj -f net11.0- 46 tests, 0 failures, 1 existing platform skipdotnet build ./tests/System.Runtime.Caching.Tests.csproj -f net481 --no-restoredotnet build ./tests/System.Runtime.Caching.Tests.csproj -f net11.0-windows --no-restoreFixes #102341