Add a scheduled code-review orchestrator and path-specific review instructions by jeffhandley · Pull Request #130339 · dotnet/runtime

jeffhandley · 2026-07-08T08:45:41Z

Summary

Reworks the repo's customized code-review automation into two related parts:

A scheduled orchestrator + per-PR worker that replaces the previous
pull_request-triggered code-review.md.
Path-specific review instructions broken out of the code-review skill so the
built-in Copilot code review agent applies them too.

This is separate from -- and complements -- GitHub's built-in Copilot code review agent.
The dispatched worker posts a single holistic review comment ("Holistic Runtime Review")
on each PR.

Changes

Scheduled orchestrator / worker

code-review-orchestrator.md -- on a 10-minute schedule (and workflow_dispatch),
polls open PRs, computes the new/updated set deterministically from a reviewed-SHA
actions/cache, and dispatches the worker per PR via the dispatch-workflow safe output.
Follows the OrchestratorOps, DeterministicOps, and WorkQueueOps patterns from gh-aw.
code-review.md -- reworked from a pull_request-triggered workflow into a per-PR
worker (workflow_dispatch); reviews one PR using the code-review skill and posts one
holistic comment.
Both run in the copilot-pat-pool environment and draw a token from the Copilot PAT pool
(shared/pat_pool.md), matching the convention already in main.

Path-specific review instructions

The review rules move verbatim out of .github/skills/code-review/SKILL.md into path-scoped
instruction files, each with an applyTo glob:

review-all-src.instructions.md (src/**) -- reviewer mindset, Holistic PR Assessment,
PR hygiene, codebase consistency, documentation.
review-csharp.instructions.md (**/*.cs) -- error handling, thread safety, security,
correctness patterns, performance/allocations, API design, code style.
review-native.instructions.md (C/C++/asm globs) -- JIT-specific correctness, C++ style,
runtime/VM patterns, native performance, platform defines, P/Invoke marshalling.
review-all-tests.instructions.md (test globs) -- testing rules.

Copilot agents -- including the built-in Copilot code review agent -- automatically respect
.github/instructions/**/*.instructions.md files whose applyTo glob matches the changed
files, so these rules now apply to native Copilot reviews in addition to the code-review skill.
SKILL.md is slimmed to the review process and points at the new files.

Validation

Exercised end-to-end in a private test repo across native, C#, test, and non-src PRs:
orchestrator pickup, per-PR dispatch, holistic worker comments, native Copilot reviews that
reflect the path-specific instructions, WorkQueue dedup (no re-review when unchanged), and
re-review when new commits are pushed.

Notes

On the scheduled trigger the workflows self-skip when the repo is a fork
(!github.event.repository.fork); workflow_dispatch always runs. Fork PRs themselves are
still reviewed (see the security note in the orchestrator's poll step).

Move the general, language-agnostic review criteria (reviewer mindset, Holistic PR Assessment, PR hygiene, codebase consistency, and documentation) verbatim out of .github/skills/code-review/SKILL.md into a path-specific instruction file scoped to src/**, and point the skill at the new file. Copilot agents -- including the Copilot code review agent -- automatically respect .github/instructions/**/*.instructions.md files whose applyTo glob matches the changed files, so these rules now apply to native Copilot reviews in addition to the code-review skill. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Move the C# rules (error handling, thread safety, security, correctness patterns, performance/allocations, API design, and code style) verbatim out of the skill into a file scoped to **/*.cs, and add the loading reference. Copilot agents -- including the Copilot code review agent -- automatically respect .github/instructions/**/*.instructions.md files whose applyTo glob matches the changed files, so these C# rules now apply to native Copilot reviews of C# files in addition to the code-review skill. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Move the native rules (JIT-specific correctness, C++ style, runtime/VM patterns, native performance, platform defines, and P/Invoke marshalling) verbatim out of the skill into a file scoped to the C/C++/asm globs, and add the loading reference. Copilot agents -- including the Copilot code review agent -- automatically respect .github/instructions/**/*.instructions.md files whose applyTo glob matches the changed files, so these native rules now apply to native Copilot reviews of native files in addition to the code-review skill. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Move the testing rules verbatim out of the skill into a file scoped to the test globs, and add the loading reference. The skill now contains only the review process and points to the path-specific instruction files. Copilot agents -- including the Copilot code review agent -- automatically respect .github/instructions/**/*.instructions.md files whose applyTo glob matches the changed files, so these test rules now apply to native Copilot reviews of test files in addition to the code-review skill. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…trator - Add code-review-orchestrator.md: on a 10-minute schedule (and workflow_dispatch) it polls open PRs, computes the new/updated set deterministically from a reviewed-SHA actions/cache, and dispatches the code-review workflow per PR via the dispatch-workflow safe output. - Rework code-review.md from a pull_request-triggered workflow into a per-PR worker (workflow_dispatch) dispatched by the orchestrator; it reviews one PR using the code-review skill and posts a single holistic comment. - Both import the Copilot PAT pool; update .github/aw/actions-lock.json for the pinned actions the new locks use. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

dotnet-policy-service · 2026-07-08T08:46:55Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR restructures the repo’s customized Copilot-based review automation into a scheduled “orchestrator + per-PR worker” model and moves detailed review guidance into path-scoped .github/instructions/*.instructions.md files so both the custom workflow and GitHub’s built-in Copilot code review can share the same rule source.

Changes:

Converts code-review into a workflow_dispatch per-PR worker and adds a scheduled orchestrator that deterministically selects PRs needing (re)review and dispatches the worker.
Splits language-/area-specific review guidance out of the code-review skill into path-scoped instruction files under .github/instructions/.
Updates the Agentic Workflows action pinning to include actions/cache/*@v4 to support the new orchestrator’s state caching.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
.github/workflows/code-review.md	Reworks the workflow into a per-PR `workflow_dispatch` worker with updated safe-outputs / concurrency and PAT-pool handling.
.github/workflows/code-review.lock.yml	Regenerated lockfile reflecting the worker model and updated tool/container configuration.
.github/workflows/code-review-orchestrator.md	New scheduled orchestrator that computes a deterministic dispatch list and fans out worker dispatches.
.github/workflows/code-review-orchestrator.lock.yml	New lockfile for the orchestrator workflow.
.github/skills/code-review/SKILL.md	Slims the skill to process + points at path-scoped instruction files; updates output header text.
.github/instructions/review-all-src.instructions.md	New “general” source review criteria for `src/**`.
.github/instructions/review-csharp.instructions.md	New C#-specific review criteria (`*/.cs`).
.github/instructions/review-native.instructions.md	New native/interop review criteria (C/C++/asm globs).
.github/instructions/review-all-tests.instructions.md	New test review criteria (tests globs).
.github/aw/actions-lock.json	Adds pinned SHAs for `actions/cache/restore@v4` and `actions/cache/save@v4`.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

# Conflicts: # .github/workflows/code-review.lock.yml # .github/workflows/code-review.md

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…hestration' into jeffhandley/code-review-orchestration

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

+  # The per-PR job-discriminator gives each PR's compiler-generated jobs (agent, safe_outputs,
+  # conclusion) a distinct concurrency slot, so concurrently dispatched workers for different PRs
+  # run independently; cancel-in-progress above still cancels a stale review when the same PR is
+  # pushed again.
+  job-discriminator: ${{ github.event.inputs.pr_number }}


  github:
-    mode: remote
+    # Use the default containerized github-mcp-server, authenticated with the Actions GITHUB_TOKEN.
    toolsets: [default, search]


Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

+      gh pr list --repo "$GITHUB_REPOSITORY" --state open --limit 1000 \
+        --json number,headRefOid,isDraft,updatedAt,isCrossRepository \
+        --jq '[.[] | select(.isDraft == false)]' > /tmp/open_prs.json
+      echo "Open non-draft PRs: $(jq 'length' /tmp/open_prs.json) (forks included)"


Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

jeffhandley and others added 5 commits July 8, 2026 03:56

Copilot AI review requested due to automatic review settings July 8, 2026 08:45

jeffhandley requested a review from a team as a code owner July 8, 2026 08:45

github-actions Bot added the area-Infrastructure label Jul 8, 2026

github-project-automation Bot added this to Runtime Infra Jul 8, 2026

Copilot started reviewing on behalf of jeffhandley July 8, 2026 08:46 View session

dotnet-policy-service Bot assigned jeffhandley Jul 8, 2026

Copilot AI reviewed Jul 8, 2026

View reviewed changes

Comment thread .github/skills/code-review/SKILL.md Outdated

jeffhandley added area-skills Agent Skills and removed area-Infrastructure labels Jul 8, 2026

Improve statement for referencing review-all-src.instructions.md

7d911b4

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 8, 2026 09:00

Copilot started reviewing on behalf of jeffhandley July 8, 2026 09:01 View session

Copilot AI reviewed Jul 8, 2026

View reviewed changes

Comment thread .github/workflows/code-review.md

Comment thread .github/skills/code-review/SKILL.md Outdated

Comment thread .github/instructions/review-native.instructions.md

Apply suggestions from code review

2d04149

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 8, 2026 09:17

Copilot started reviewing on behalf of jeffhandley July 8, 2026 09:18 View session

Copilot AI reviewed Jul 8, 2026

View reviewed changes

Comment thread .github/workflows/code-review.md

Comment thread .github/skills/code-review/SKILL.md Outdated

Comment thread .github/workflows/code-review-orchestrator.md

jeffhandley and others added 2 commits July 8, 2026 05:29

Merge branch 'main' into jeffhandley/code-review-orchestration

bb9a33d

# Conflicts: # .github/workflows/code-review.lock.yml # .github/workflows/code-review.md

Apply suggestions from code review

a72341e

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 8, 2026 09:35

Copilot started reviewing on behalf of jeffhandley July 8, 2026 09:36 View session

Merge remote-tracking branch 'jeffhandley/jeffhandley/code-review-orc…

e05ac2b

…hestration' into jeffhandley/code-review-orchestration

Copilot AI reviewed Jul 8, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 8, 2026 09:44

Copilot started reviewing on behalf of jeffhandley July 8, 2026 09:44 View session

Copilot AI reviewed Jul 8, 2026

View reviewed changes

jeffhandley commented Jul 8, 2026

View reviewed changes

Comment thread .github/workflows/code-review.md Outdated

Remove unnecessary comment for tools.github

1959987

Copilot AI review requested due to automatic review settings July 8, 2026 14:02

Copilot started reviewing on behalf of jeffhandley July 8, 2026 14:03 View session

Copilot AI reviewed Jul 8, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add a scheduled code-review orchestrator and path-specific review instructions#130339

Add a scheduled code-review orchestrator and path-specific review instructions#130339
jeffhandley wants to merge 11 commits into
dotnet:mainfrom
jeffhandley:jeffhandley/code-review-orchestration

jeffhandley commented Jul 8, 2026

Uh oh!

dotnet-policy-service Bot commented Jul 8, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jeffhandley commented Jul 8, 2026

Summary

Changes

Scheduled orchestrator / worker

Path-specific review instructions

Validation

Notes

Uh oh!

dotnet-policy-service Bot commented Jul 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants