Remove always-on NullableOptionalInterop language feature flag - #20378
Open
T-Gro wants to merge 3 commits into
Open
Remove always-on NullableOptionalInterop language feature flag#20378T-Gro wants to merge 3 commits into
T-Gro wants to merge 3 commits into
Conversation
The LanguageFeature.NullableOptionalInterop flag is permanently enabled since the minimum accepted --langversion is 8.0. Remove the dead SupportsFeature checks in the Checking layer and simplify the surrounding branches, deleting the now-unreachable match arms. No behavioural change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The NullableOptionalInterop language feature shipped in F# 5.0 and is permanently enabled because the minimum accepted --langversion is 8.0. Remove the now-unused union case, features-map entry, GetFeatureString arm, and the featureNullableOptionalInterop resource string, then regenerate the xlf localization files via /t:UpdateXlf. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro
added
the
NO_RELEASE_NOTES
Contributor
|
github-actions
Bot
added
the
⚠️ Affects-Compiler-Output
Contributor
|
🔍 Tooling Safety Check — Affects-Compiler-Output
|
T-Gro
added
NO_RELEASE_NOTES
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20154
LanguageFeature.NullableOptionalInterophas been permanently enabled since F# 5.0 (the minimum accepted--langversionis 8.0), so its flag could never be turned off. Removed the dead flag and collapsed every guarded site to its enabled path. As a consequence,--disableLanguageFeature:NullableOptionalInteropis no longer a recognized feature name.