Flatten always-on LanguageFeature.NameOf flag - #20377
Open
T-Gro wants to merge 2 commits into
Open
Conversation
T-Gro
added
the
NO_RELEASE_NOTES
Contributor
|
github-actions
Bot
added
the
AI-Tooling-Check-Bypassed
The nameof operator (LanguageFeature.NameOf) shipped in F# 5.0 and is enabled for every accepted --langversion (min 8.0), so its feature flag is dead configuration. Simplify all enforcement-site checks to their enabled behavior and delete the helpers/members that thereby became constant. Retarget the disableLanguageFeature tests to StringInterpolation. The union case itself is removed in a later sprint. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Delete the LanguageFeature.NameOf union case, its features-map entry, and its GetFeatureString arm. Remove the featureNameOf FSComp string and re-word the FS3881 optsUnrecognizedLanguageFeature example (which named NameOf) to reference StringInterpolation/NullnessChecking. Regenerate all xlf files via UpdateXlf. The nameof operator implementation is unchanged; only the dead feature flag (F# 5.0, min langversion 8.0) is removed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro
added
NO_RELEASE_NOTES
T-Gro
enabled auto-merge (squash)
August 27, 2026 09:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20153
The
NameOflanguage feature has been enabled unconditionally since F# 5.0, so its flag was dead weight. Removed the flag and collapsed everySupportsFeature LanguageFeature.NameOfguard to its enabled path.