Remove always-on language feature flag PreferStringGetPinnableReference - #20370
Open
T-Gro wants to merge 1 commit into
Open
Remove always-on language feature flag PreferStringGetPinnableReference#20370T-Gro wants to merge 1 commit into
T-Gro wants to merge 1 commit into
Conversation
…ce (#20186) The PreferStringGetPinnableReference feature shipped in F# 8.0 and is on for every selectable language version (minimum langversion is 8.0), so its flag is dead configuration. Remove the LanguageFeature DU case, features-map entry, GetFeatureString arm, FSComp.txt resource string, and collapse the single guarded path in TcAndBuildFixedExpr to the always-on GetPinnableReference call. Regenerate xlf files. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro
added
the
NO_RELEASE_NOTES
github-actions
Bot
added
the
AI-Tooling-Check-Bypassed
T-Gro
added
NO_RELEASE_NOTES
Contributor
|
T-Gro
enabled auto-merge (squash)
August 27, 2026 09:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20186
PreferStringGetPinnableReferenceshipped in F# 8.0 and is on for every selectable language version, so its flag was dead configuration. Removed the flag and collapsed the guardedTcAndBuildFixedExprpath to its always-onGetPinnableReferencebehavior.